Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch to ecr for faster image pull #364

Merged
merged 5 commits into from
Aug 15, 2022
Merged

fix: switch to ecr for faster image pull #364

merged 5 commits into from
Aug 15, 2022

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Aug 15, 2022

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

supabase start was extremely slow due to image pulling

What is the new behavior?

  • used mirrored images from ecr (x86 only)
  • takes 2 mins to pull everything

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from soedirgo as a code owner August 15, 2022 08:40
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2859946111

  • 1 of 67 (1.49%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 24.084%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/gen/types/typescript/typescript.go 0 3 0.0%
internal/utils/container_output.go 0 5 0.0%
internal/db/remote/changes/changes.go 0 6 0.0%
internal/db/remote/commit/commit.go 0 6 0.0%
internal/utils/docker.go 0 13 0.0%
internal/start/start.go 0 33 0.0%
Totals Coverage Status
Change from base Build 2857795865: 0.2%
Covered Lines: 1196
Relevant Lines: 4966

💛 - Coveralls

@sweatybridge sweatybridge merged commit 7032d44 into main Aug 15, 2022
@sweatybridge sweatybridge deleted the v1c branch August 15, 2022 10:30
@github-actions
Copy link

🎉 This PR is included in version 1.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants