fix: implement exponential back off on the retries of _refreshAccessToken method
#869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshukertjr
changed the title
_refreshAccessToken
dshukertjr
commented
Apr 1, 2024
dshukertjr
changed the title
_refreshAccessToken method
kangmingtay
approved these changes
Apr 15, 2024
kangmingtay
pushed a commit
that referenced
this pull request
Apr 18, 2024
🤖 I have created a release *beep* *boop* --- ## [2.63.1](v2.63.0...v2.63.1) (2024-04-18) ### Bug Fixes * `getUser` returns null if there is no session ([#876](#876)) ([6adf8ca](6adf8ca)) * implement exponential back off on the retries of `_refreshAccessToken` method ([#869](#869)) ([f66711d](f66711d)) * update session warning ([#879](#879)) ([3661130](3661130)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Currently the retry interval of
_refreshAccessTokengoes 200, 400, 600, 800, where as I believe the intended intervals are 200, 400, 800, 1600...What is the current behavior?
The retry interval is multiple of 200 ms.
What is the new behavior?
The retry interval is properly set exponentially.