Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social auth broken in gotrue-js 2.45 #745

Closed
2 tasks done
ehanahamed opened this issue Jul 24, 2023 · 5 comments
Closed
2 tasks done

Social auth broken in gotrue-js 2.45 #745

ehanahamed opened this issue Jul 24, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@ehanahamed
Copy link

ehanahamed commented Jul 24, 2023

Bug report

  • I confirm this is a bug with Supabase, not with my own application.
  • I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug

Social auth worked perfectly in my app (quizfreely.ehan.dev) until today (v2.27 was published on npm today i think). When trying to sign in with google, supabase would redirect to google's auth screen and google's auth screen would redirect back to my app successfully. However supabase wouldn't sign the user in once redirected back. Email sign in still works perfectly, but social auth doesn't.

To Reproduce

  1. Use supabase-js v2.27 (I used it through a cdn, jsdelivr)
  2. Try to sign in with some social auth (In my case it's google)
  3. Supabase redirects to google auth screen
  4. Google auth screen redirects back to your site
  5. Your not sign-in-ed ¯\_(ツ)_/¯

How I temporarily un-broke my app

This problem does not happen in v2.26 (which is why it only started happening to me today), so I downgraded to v2.26 and now everything works! ¯\_(ツ)_/¯

System information

  • Browser: Chrome
  • Version of supabase-js: 2.27

Additional context

This is probably NOT the same problem as (#811), because supabase/supabase-js#811 mentions that their problem still happens in 2.26, while my problem is solved in 2.26 and only happens in 2.27

@ehanahamed ehanahamed added the bug Something isn't working label Jul 24, 2023
@soedirgo
Copy link
Member

I think you meant v2.26 and v2.27 instead of v2.6 and v2.7?

@soedirgo soedirgo transferred this issue from supabase/supabase-js Jul 24, 2023
@ehanahamed
Copy link
Author

ehanahamed commented Jul 24, 2023

@soedirgo Yea, my bad, I meant 2.27 and 2.26, I edited it now to avoid confusion

@ehanahamed ehanahamed changed the title Social auth broken in supabase-js v2.7 (works in v2.6.0) Social auth broken in supabase-js v2.27 (works in v2.26) Jul 24, 2023
@ehanahamed ehanahamed changed the title Social auth broken in supabase-js v2.27 (works in v2.26) Social auth broken in gotrue-js 2.45 Jul 25, 2023
@ehanahamed
Copy link
Author

ehanahamed commented Jul 25, 2023

The issue is "fixed" in supbase-js v2.29 because they rolled back to an older gotrue-js version (2.43.1), see supabase/supabase-js#817 for more info.

Since the problem still exists (its just temporarily "avoided" in supbase-js), I guess I'll keep this issue open?

@j4w8n
Copy link
Contributor

j4w8n commented Jul 26, 2023

@ehanahamed this should be resolved in supabase-js v2.31.0

@ehanahamed
Copy link
Author

Yup, it's fixed in supbase-js 2.31, since it now uses gotrue-js v2.46! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants