Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getPublicURL method #26

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Fix getPublicURL method #26

merged 1 commit into from
Aug 8, 2023

Conversation

grdsdev
Copy link
Contributor

@grdsdev grdsdev commented Aug 8, 2023 •
edited
Loading

What kind of change does this PR introduce?

Fix #25

What was wrong

The current implementation was:

  1. Replacing the URL's path with component.path = newPath instead of appending to it using component.path += newPath.
  2. Not adding the bucket as a prefix to the path.

@grdsdev grdsdev merged commit 65cae9e into main Aug 8, 2023
2 checks passed
@grdsdev grdsdev deleted the fix/getPublicURL branch August 8, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Supabase Storage .getPublicUrl is not working correctly
1 participant
@grdsdev