Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add notion to enum of providers #70

Merged
merged 2 commits into from
Jan 17, 2022

Conversation

leynier
Copy link
Contributor

@leynier leynier commented Jan 17, 2022

No description provided.

@leynier leynier added the enhancement New feature or request label Jan 17, 2022
@leynier leynier self-assigned this Jan 17, 2022
@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #70 (cd1faf3) into main (23c167e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head cd1faf3 differs from pull request most recent head 0907ad0. Consider uploading reports for the commit 0907ad0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   84.20%   84.22%   +0.01%     
==========================================
  Files          14       14              
  Lines        1051     1052       +1     
==========================================
+ Hits          885      886       +1     
  Misses        166      166              
Impacted Files Coverage Δ
gotrue/__init__.py 100.00% <100.00%> (ø)
gotrue/types.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5034285...0907ad0. Read the comment docs.

Co-authored-by: Sourcery AI <>
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 17, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.47%.

Quality metrics Before After Change
Complexity 0.15 ⭐ 0.13 ⭐ -0.02 👍
Method Length 52.67 ⭐ 53.00 ⭐ 0.33 👎
Working memory 5.12 ⭐ 5.16 ⭐ 0.04 👎
Quality 80.44% 79.97% -0.47% 👎
Other metrics Before After Change
Lines 130 129 -1
Changed files Quality Before Quality After Quality Change
gotrue/types.py 80.44% ⭐ 79.97% ⭐ -0.47% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@leynier leynier merged commit a8f2c45 into main Jan 17, 2022
@leynier leynier deleted the feat/add-notion-to-enum-of-providers branch January 17, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants