Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return type in v8.1 #16

Open
raicho opened this issue Jun 29, 2023 · 2 comments
Open

Return type in v8.1 #16

raicho opened this issue Jun 29, 2023 · 2 comments

Comments

@raicho
Copy link

raicho commented Jun 29, 2023

Just reporting notice in 8.1.
"Return type of Sunspikes\Ratelimit\Throttle\Throttler\ElasticWindowThrottler::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange].

@plotbox-io
Copy link
Contributor

Have added a pull request to solve. Not sure if this repo is maintained going by the last commits :-/ but we'll be using our fork for time being to get around this - https://github.com/plotbox-io/php-ratelimiter

@sebclick
Copy link

sebclick commented Mar 6, 2024

Hello @sunspikes
Is a new version planned to take these changes into account ?
Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants