Release v1.21.1 #1106
Release v1.21.1 #1106
Conversation
WalkthroughThis pull request updates version references from 1.21.0 to 1.21.1 throughout various documentation files. The changes include modifications to hyperlinks in HTML documents, adjustments in JSON release files, and alteration of the Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1106 +/- ##
=======================================
Coverage 78.48% 78.48%
=======================================
Files 122 122
Lines 15918 15918
Branches 2607 2607
=======================================
Hits 12493 12493
Misses 3406 3406
Partials 19 19 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
docs/third-party-licenses/118.txt (1)
10-17: Disclaimer Clause Enhancement:
The disclaimer is correctly provided; however, note that the phrase “WITH REGARD TO” may be a bit wordy. Consider simplifying it (e.g., using “regarding”) and review the punctuation—adding a comma after “this software” could improve clarity.🧰 Tools
🪛 LanguageTool
[style] ~10-~10: ‘WITH REGARD TO’ might be wordy. Consider a shorter alternative.
Context: ...AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WAR...(EN_WORDINESS_PREMIUM_WITH_REGARD_TO)
[uncategorized] ~11-~11: Possible missing comma found.
Context: ...AIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MER...(AI_HYDRA_LEO_MISSING_COMMA)
docs/third-party-licenses/123.txt (1)
1-29: License Update Validation.
The license text has been comprehensively replaced, switching from the previous MIT License to a Mozilla Foundation License, complete with updated copyright years, conditions, and disclaimer. Given the sensitivity of license changes, please ensure that this update is intentional and aligns with the project's licensing policy.If needed, I can help verify compatibility or assist with any queries regarding the new license terms.
docs/third-party-licenses/117.txt (1)
9-10: Minor Wording and Punctuation Consideration in Disclaimer
Static analysis suggests that the phrase “WITH REGARD TO” (line 9) might be wordy and that a comma might be missing (line 10). For example, you might consider revising the text to:- THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF + THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES regarding this software, including all implied warranties ofNote: Because this is legal text, please consult your legal standards before making any changes.
🧰 Tools
🪛 LanguageTool
[style] ~9-~9: ‘WITH REGARD TO’ might be wordy. Consider a shorter alternative.
Context: ...AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WAR...(EN_WORDINESS_PREMIUM_WITH_REGARD_TO)
[uncategorized] ~10-~10: Possible missing comma found.
Context: ...AIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MER...(AI_HYDRA_LEO_MISSING_COMMA)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (51)
docs/index.en.html(1 hunks)docs/index.html(1 hunks)docs/index.zh_tw.html(1 hunks)docs/release-linux.json(1 hunks)docs/release-mac.json(1 hunks)docs/release-win.json(1 hunks)docs/release.json(1 hunks)docs/third-party-licenses.html(1 hunks)docs/third-party-licenses/109.txt(1 hunks)docs/third-party-licenses/110.txt(1 hunks)docs/third-party-licenses/111.txt(1 hunks)docs/third-party-licenses/112.txt(1 hunks)docs/third-party-licenses/113.txt(1 hunks)docs/third-party-licenses/114.txt(1 hunks)docs/third-party-licenses/115.txt(1 hunks)docs/third-party-licenses/116.txt(1 hunks)docs/third-party-licenses/117.txt(1 hunks)docs/third-party-licenses/118.txt(1 hunks)docs/third-party-licenses/119.txt(2 hunks)docs/third-party-licenses/120.txt(1 hunks)docs/third-party-licenses/121.txt(2 hunks)docs/third-party-licenses/122.txt(1 hunks)docs/third-party-licenses/123.txt(1 hunks)docs/third-party-licenses/124.txt(1 hunks)docs/third-party-licenses/125.txt(1 hunks)docs/third-party-licenses/126.txt(1 hunks)docs/third-party-licenses/127.txt(1 hunks)docs/third-party-licenses/128.txt(1 hunks)docs/third-party-licenses/129.txt(1 hunks)docs/third-party-licenses/130.txt(1 hunks)docs/third-party-licenses/131.txt(1 hunks)docs/third-party-licenses/132.txt(1 hunks)docs/third-party-licenses/133.txt(1 hunks)docs/third-party-licenses/134.txt(1 hunks)docs/third-party-licenses/135.txt(1 hunks)docs/third-party-licenses/136.txt(1 hunks)docs/third-party-licenses/137.txt(1 hunks)docs/third-party-licenses/138.txt(1 hunks)docs/third-party-licenses/139.txt(1 hunks)docs/third-party-licenses/140.txt(1 hunks)docs/third-party-licenses/141.txt(1 hunks)docs/third-party-licenses/142.txt(1 hunks)docs/webapp-dev/index.html(1 hunks)docs/webapp-dev/layout-manager.html(1 hunks)docs/webapp-dev/monitor.html(1 hunks)docs/webapp-dev/prompt.html(1 hunks)docs/webapp/index.html(1 hunks)docs/webapp/layout-manager.html(1 hunks)docs/webapp/monitor.html(1 hunks)docs/webapp/prompt.html(1 hunks)package.json(1 hunks)
✅ Files skipped from review due to trivial changes (32)
- package.json
- docs/third-party-licenses/137.txt
- docs/third-party-licenses/127.txt
- docs/third-party-licenses/109.txt
- docs/third-party-licenses/125.txt
- docs/third-party-licenses/111.txt
- docs/third-party-licenses/121.txt
- docs/third-party-licenses/139.txt
- docs/third-party-licenses/136.txt
- docs/third-party-licenses/134.txt
- docs/third-party-licenses/110.txt
- docs/third-party-licenses/132.txt
- docs/webapp/index.html
- docs/webapp/monitor.html
- docs/third-party-licenses/131.txt
- docs/third-party-licenses/142.txt
- docs/third-party-licenses/135.txt
- docs/third-party-licenses/124.txt
- docs/third-party-licenses/126.txt
- docs/third-party-licenses/140.txt
- docs/index.zh_tw.html
- docs/release-linux.json
- docs/third-party-licenses/129.txt
- docs/release-mac.json
- docs/third-party-licenses/115.txt
- docs/third-party-licenses/128.txt
- docs/third-party-licenses/122.txt
- docs/third-party-licenses/119.txt
- docs/third-party-licenses/138.txt
- docs/third-party-licenses/113.txt
- docs/release-win.json
- docs/release.json
🧰 Additional context used
🪛 LanguageTool
docs/third-party-licenses/133.txt
[style] ~51-~51: ‘any and all’ might be wordy. Consider a shorter alternative.
Context: ...ge, computer failure or malfunction, or any and all other commercial damages or losses), ev...
(EN_WORDINESS_PREMIUM_ANY_AND_ALL)
docs/third-party-licenses/118.txt
[style] ~10-~10: ‘WITH REGARD TO’ might be wordy. Consider a shorter alternative.
Context: ...AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WAR...
(EN_WORDINESS_PREMIUM_WITH_REGARD_TO)
[uncategorized] ~11-~11: Possible missing comma found.
Context: ...AIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MER...
(AI_HYDRA_LEO_MISSING_COMMA)
docs/third-party-licenses/116.txt
[style] ~9-~9: ‘WITH REGARD TO’ might be wordy. Consider a shorter alternative.
Context: ...AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WAR...
(EN_WORDINESS_PREMIUM_WITH_REGARD_TO)
docs/third-party-licenses/112.txt
[style] ~1-~1: Using many exclamation marks might seem excessive (in this case: 6 exclamation marks for a text that’s 3601 characters long)
Context: 
[
[uncategorized] ~52-~52: Loose punctuation mark.
Context: ...romise** stream: ReadableStream: the [Web-API readable stream](https://d...
(UNLIKELY_OPENING_PUNCTUATION)
[typographical] ~58-~58: The word “otherwise” is an adverb that can’t be used like a conjunction, and therefore needs to be separated from the sentence.
Context: ... to Web-API ReadableStream immediately returns, otherwise it will wait until the read is resolved...
(THUS_SENTENCE)
docs/third-party-licenses/117.txt
[style] ~9-~9: ‘WITH REGARD TO’ might be wordy. Consider a shorter alternative.
Context: ...AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WAR...
(EN_WORDINESS_PREMIUM_WITH_REGARD_TO)
[uncategorized] ~10-~10: Possible missing comma found.
Context: ...AIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MER...
(AI_HYDRA_LEO_MISSING_COMMA)
docs/third-party-licenses/141.txt
[style] ~7-~7: ‘WITH REGARD TO’ might be wordy. Consider a shorter alternative.
Context: ...AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WAR...
(EN_WORDINESS_PREMIUM_WITH_REGARD_TO)
[uncategorized] ~8-~8: Possible missing comma found.
Context: ...AIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MER...
(AI_HYDRA_LEO_MISSING_COMMA)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: build
- GitHub Check: Analyze (javascript)
🔇 Additional comments (32)
docs/third-party-licenses/141.txt (3)
1-2: License Header VerificationThe copyright notice for Eemeli Aro and the associated email address are correctly formatted and conform to the standard legal text.
3-6: Permission Statement ConformanceThe permission notice follows the standard ISC license language, clearly granting rights to use, copy, modify, and distribute the software, provided the notices remain intact. No changes are necessary.
7-13: Warranty Disclaimer - Maintain Legal Text IntegrityThe disclaimer section faithfully reproduces the ISC license wording. Although static analysis hints flag "WITH REGARD TO" as potentially wordy and note a possible missing comma, such modifications are not recommended for legal texts. Altering these phrases might inadvertently change the legal meaning. Please keep the text as-is to preserve its legal integrity.
🧰 Tools
🪛 LanguageTool
[style] ~7-~7: ‘WITH REGARD TO’ might be wordy. Consider a shorter alternative.
Context: ...AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WAR...(EN_WORDINESS_PREMIUM_WITH_REGARD_TO)
[uncategorized] ~8-~8: Possible missing comma found.
Context: ...AIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MER...(AI_HYDRA_LEO_MISSING_COMMA)
docs/third-party-licenses/118.txt (2)
1-4: License Header Update:
The ISC License header and attribution have been updated (changing the original ownership to "2015, Contributors"). Verify that this change is in line with the project’s overall licensing strategy.
5-9: Permission Clause Verification:
The permission statement clearly outlines the rights to use, copy, modify, and distribute the software. This is consistent with the ISC License requirements.docs/third-party-licenses/120.txt (3)
1-4: MIT License Header Update:
The license header is now updated to reflect the MIT License along with the new attribution ("Copyright (c) DC threedeecee@gmail.com").
5-8: Permission and Conditions Statement:
The permission clause and the accompanying conditions (i.e. inclusion of the copyright and permission notice)
are in full accordance with the MIT License standards.
9-10: Disclaimer Clause Confirmation:
The software disclaimer is written per MIT License conventions. Ensure that this change aligns with the rest of the project's licensing documentation.docs/third-party-licenses/130.txt (4)
1-2: License Attribution Update:
The header now attributes the license text to Brian Grinstead and includes his URL. Confirm that this attribution is compliant with project guidelines.
3-9: Permission Clause Check:
The permission clause offers the expected freedoms under a permissive license. The language is clear and aligns well with standard practices.
11-13: Notice Inclusion Requirement:
The clause requiring inclusion of the copyright and permission
notice in all copies or substantial portions is correctly stated.
14-20: Disclaimer Clause Verification:
The disclaimer clause is clear, standard, and follows the common MIT License style.docs/third-party-licenses/114.txt (4)
1-2: License Header and Attribution Update:
The header now reflects the updated attribution to David Mark Clements (2019), and the formatting appears correct.
3-6: Permission Grant Text:
The permission clause is comprehensive and clearly grants the necessary rights, consistent with a permissive license.
8-9: Notice Inclusion Requirement:
The statement mandating the inclusion of this notice in all copies is well stated and meets standard practices.
11-15: Disclaimer Statement Examination:
The disclaimer, provided “AS IS” without warranties, is standard and appears well integrated. Confirm that the rephrasing is intentional and legally compliant.docs/webapp-dev/prompt.html (1)
31-31: Application Version Update:
TheappVersionproperty inwindow.electronShogihas been updated to "1.21.1", which correctly reflects the new release version. Ensure that similar version updates remain consistent across all relevant files.docs/webapp/prompt.html (1)
29-33: Version Update Correctness.
TheappVersionproperty within thewindow.electronShogiobject has been updated from "1.21.0" to "1.21.1", aligning with the release's version update requirements. This change is straightforward and consistent with the PR objectives.docs/webapp-dev/monitor.html (1)
30-34: Version Update Consistency.
TheappVersionproperty has been updated to "1.21.1" here as well, ensuring that the monitor view reflects the new release version. The update is clear and consistent with changes in other related files.docs/webapp/layout-manager.html (1)
31-34: Version Update Consistency.
The update toappVersion: "1.21.1"ensures that the version displayed in the Layout Manager is in line with the overall release. This change is straightforward and meets the release guidelines.docs/webapp-dev/layout-manager.html (1)
31-34: Version Update Consistency and Accuracy.
Here, theappVersionproperty has been updated to "1.21.1", mirroring the changes across the project. This update correctly reflects the current release version with no issues noted.docs/webapp-dev/index.html (1)
35-39: App Version Update Verification
TheappVersionproperty inwindow.electronShogihas been updated to"1.21.1"as required for the new release. This change is straightforward and aligns with the version update across the project. Please verify that any code or documentation references to this property are updated accordingly.docs/third-party-licenses/116.txt (2)
1-17: License Transition to ISC License
The license text has been completely replaced with the ISC License, and the attribution now correctly identifies "Copyright (c) 2010-2024 Isaac Z. Schlueter and Contributors." This ensures the license complies with the desired legal framework for the project.🧰 Tools
🪛 LanguageTool
[style] ~9-~9: ‘WITH REGARD TO’ might be wordy. Consider a shorter alternative.
Context: ...AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WAR...(EN_WORDINESS_PREMIUM_WITH_REGARD_TO)
17-24: Addition of Dual Licensing forString.fromCodePoint
An extra section has been added to document the use ofString.fromCodePointunder the MIT License, complete with appropriate copyright and permission terms. This dual licensing note is clear and properly isolated from the main license.docs/third-party-licenses/112.txt (2)
1-7: Enhanced Documentation Badges Added
The addition of multiple badges (CI tests, NPM version, downloads, vulnerability, code quality, coverage, and minified size) at the top of the file improves transparency regarding the package's status. These links should remain maintained as the project evolves.🧰 Tools
🪛 LanguageTool
[style] ~1-~1: Using many exclamation marks might seem excessive (in this case: 6 exclamation marks for a text that’s 3601 characters long)
Context:
[
9-9: Project Title Declaration
The project title "# readable-web-to-node-stream" has been clearly set, helping users immediately understand the context of the file.docs/third-party-licenses/133.txt (2)
1-56: Adoption of Apache License 2.0
This file now contains the full text of the Apache License 2.0, replacing the previous MIT License. This significant change in legal terms is implemented in full, including all necessary definitions, license grants, and conditions. Ensure that all contributors and users are made aware of this change.🧰 Tools
🪛 LanguageTool
[style] ~51-~51: ‘any and all’ might be wordy. Consider a shorter alternative.
Context: ...ge, computer failure or malfunction, or any and all other commercial damages or losses), ev...(EN_WORDINESS_PREMIUM_ANY_AND_ALL)
51-51: Legal Text Style Note
The phrase "any and all" appears in the license text. Given that this is standard legal language within the Apache License, the stylistic suggestion to simplify it can be safely ignored.🧰 Tools
🪛 LanguageTool
[style] ~51-~51: ‘any and all’ might be wordy. Consider a shorter alternative.
Context: ...ge, computer failure or malfunction, or any and all other commercial damages or losses), ev...(EN_WORDINESS_PREMIUM_ANY_AND_ALL)
docs/index.html (1)
160-163: PCアプリ Release Link Update
The hyperlink for the "最新版 (Version 1.21.1)" in the PCアプリ section has been updated to point to the correct release tag. This ensures end users are directed to the latest release page.docs/index.en.html (1)
159-161: Version Link Update Confirmed
The "Latest (Version 1.21.1)" link has been updated correctly to point to the new release. Verify that all corresponding version references in related files remain consistent.docs/third-party-licenses.html (1)
1-142: New License Entry and Update Verification
A new table row for proper‑lockfile has been added with the correct MIT license, publisher "André Cruz", and repository link. In addition, the entry for streamroller has been updated to reflect the proper license type (MIT) and publisher "Gareth Jones" with the updated repository URL. Please double-check that these details are correct and that the links resolve as expected.docs/third-party-licenses/117.txt (1)
1-16: ISC License Text Update
The license text has been updated from the previous MIT text to the ISC License. The new copyright notice and permission details appear to be correct and in line with the update.🧰 Tools
🪛 LanguageTool
[style] ~9-~9: ‘WITH REGARD TO’ might be wordy. Consider a shorter alternative.
Context: ...AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WAR...(EN_WORDINESS_PREMIUM_WITH_REGARD_TO)
[uncategorized] ~10-~10: Possible missing comma found.
Context: ...AIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MER...(AI_HYDRA_LEO_MISSING_COMMA)
説明 / Description
v1.21.1 リリース
チェックリスト / Checklist
npm testpassednpm run lintwas applied without warnings/docs/webappnot included (except release branch)console.lognot included (except script file)Summary by CodeRabbit