Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

評価値グラフのデータポイントをクリックしたときのツールチップ(吹き出し)を無効化 #1092

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

sunfish-shogi
Copy link
Owner

@sunfish-shogi sunfish-shogi commented Jan 26, 2025

説明 / Description

#1090

チェックリスト / Checklist

  • MUST
    • npm test passed
    • npm run lint was applied without warnings
    • changes of /docs/webapp not included (except release branch)
    • console.log not included (except script file)
  • MUST for Outside Contributor
  • RECOMMENDED (it depends on what you change)
    • unit test added/updated
    • i18n

Summary by CodeRabbit

  • Bug Fixes
    • Disabled chart tooltips to improve user experience and prevent potential display issues.

@sunfish-shogi sunfish-shogi self-assigned this Jan 26, 2025
Copy link

coderabbitai bot commented Jan 26, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request modifies the EvaluationChart.vue component by updating the chart configuration to disable tooltips. This change specifically involves setting the tooltip plugin option to false within the chart's options, which prevents tooltip interactions when users hover over data points in the chart.

Changes

File Change Summary
src/renderer/view/tab/EvaluationChart.vue Disabled chart tooltips by setting chart.options.plugins.tooltip.enabled = false

Poem

🐰 A chart without a whisper's trace,
No tooltips dancing in this space
Silent points, no hover's might
Data speaks without a bite
A rabbit's chart, clean and bright! 🍃


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eba5b71 and 707cc70.

📒 Files selected for processing (1)
  • src/renderer/view/tab/EvaluationChart.vue (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sunfish-shogi sunfish-shogi changed the title Disable Chart.js tooltip 評価値グラフのデータポイントをクリックしたときのツールチップ(吹き出し)を無効化 Jan 26, 2025
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.86%. Comparing base (eba5b71) to head (707cc70).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1092   +/-   ##
=======================================
  Coverage   77.86%   77.86%           
=======================================
  Files         122      122           
  Lines       15933    15933           
  Branches     2587     2587           
=======================================
  Hits        12406    12406           
  Misses       3508     3508           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunfish-shogi sunfish-shogi merged commit f2b42a7 into main Jan 26, 2025
5 checks passed
@sunfish-shogi sunfish-shogi deleted the disable-chart-tooltip branch January 26, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant