Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support v1.20 #1058

Merged
merged 2 commits into from
Jan 5, 2025
Merged

Support v1.20 #1058

merged 2 commits into from
Jan 5, 2025

Conversation

sunfish-shogi
Copy link
Owner

@sunfish-shogi sunfish-shogi commented Jan 5, 2025

説明 / Description

v1.20.2 リリース

チェックリスト / Checklist

  • MUST
    • npm test passed
    • npm run lint was applied without warnings
    • changes of /docs/webapp not included (except release branch)
    • console.log not included (except script file)
  • MUST for Outside Contributor
  • RECOMMENDED (it depends on what you change)
    • unit test added/updated
    • i18n

Summary by CodeRabbit

  • New Features

    • No new features added
  • Bug Fixes

    • No specific bug fixes mentioned
  • Documentation

    • Updated version number from 1.20.1 to 1.20.2 across multiple documentation files and release notes
  • Chores

    • Updated application version to 1.20.2 in package.json and various HTML files
    • Updated release links and version references for desktop and web applications

@sunfish-shogi sunfish-shogi self-assigned this Jan 5, 2025
Copy link

coderabbitai bot commented Jan 5, 2025

Walkthrough

This pull request involves a comprehensive version update from 1.20.1 to 1.20.2 across multiple files in the ShogiHome project. The changes primarily include updating version numbers in HTML files, release JSON files, web application assets, and the package.json. The modifications span documentation, web application scripts, stylesheets, and configuration files, ensuring consistent version information throughout the project's ecosystem.

Changes

File/Path Change Summary
docs/index.* Updated version links from 1.20.1 to 1.20.2 in English, Japanese, and Chinese HTML files
docs/release-*.json Updated version, tag, and release link for Linux, Mac, Windows, and general release files
docs/webapp-dev/index.html Updated script, stylesheet references and appVersion
docs/webapp-dev/{layout-manager,monitor,prompt}.html Updated appVersion to 1.20.2
docs/webapp/index.html Updated script, stylesheet references and appVersion
docs/webapp/assets/*.js Modified import paths and localization modules
docs/webapp/assets/main-BNjJExnj.css Comprehensive CSS styling updates
package.json Updated package version to 1.20.2

Possibly related PRs

Poem

🐰 Version bump, oh what a hop!
From 1.20.1 to 1.20.2, we never stop
Docs and scripts, all in line
Updating code with a design so fine
ShogiHome leaps forward with glee! 🎉


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a55ac27 and 7057e16.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (26)
  • docs/index.en.html (1 hunks)
  • docs/index.html (1 hunks)
  • docs/index.zh_tw.html (1 hunks)
  • docs/release-linux.json (1 hunks)
  • docs/release-mac.json (1 hunks)
  • docs/release-win.json (1 hunks)
  • docs/release.json (1 hunks)
  • docs/webapp-dev/assets/en-CnYb4sXH.js (1 hunks)
  • docs/webapp-dev/assets/ja-DrRPJRij.js (1 hunks)
  • docs/webapp-dev/assets/main-BNjJExnj.css (1 hunks)
  • docs/webapp-dev/assets/zh-tw-hWHs7aVM.js (1 hunks)
  • docs/webapp-dev/index.html (3 hunks)
  • docs/webapp-dev/layout-manager.html (1 hunks)
  • docs/webapp-dev/monitor.html (1 hunks)
  • docs/webapp-dev/prompt.html (1 hunks)
  • docs/webapp/assets/en-DJdYCysv.js (1 hunks)
  • docs/webapp/assets/ja-CF1rEV3J.js (1 hunks)
  • docs/webapp/assets/ja-Cev8Pe-_.js (0 hunks)
  • docs/webapp/assets/main-BNjJExnj.css (1 hunks)
  • docs/webapp/assets/zh-tw-B63saF53.js (0 hunks)
  • docs/webapp/assets/zh-tw-BZtg_u95.js (1 hunks)
  • docs/webapp/index.html (3 hunks)
  • docs/webapp/layout-manager.html (1 hunks)
  • docs/webapp/monitor.html (1 hunks)
  • docs/webapp/prompt.html (1 hunks)
  • package.json (1 hunks)
💤 Files with no reviewable changes (2)
  • docs/webapp/assets/ja-Cev8Pe-_.js
  • docs/webapp/assets/zh-tw-B63saF53.js
✅ Files skipped from review due to trivial changes (12)
  • docs/webapp-dev/monitor.html
  • package.json
  • docs/webapp-dev/assets/ja-DrRPJRij.js
  • docs/webapp/assets/en-DJdYCysv.js
  • docs/webapp-dev/assets/en-CnYb4sXH.js
  • docs/release-win.json
  • docs/release-linux.json
  • docs/webapp-dev/assets/zh-tw-hWHs7aVM.js
  • docs/webapp-dev/assets/main-BNjJExnj.css
  • docs/release.json
  • docs/index.html
  • docs/release-mac.json
🔇 Additional comments (14)
docs/webapp/assets/ja-CF1rEV3J.js (1)

Line range hint 1-31: No issues found in the new Japanese locale module.
The code is well-structured and appears to conform to typical i18n best practices, including appropriate date/time formats and ordinal logic. It does not contain any redundant console.logs and does not introduce extraneous changes.

docs/webapp/assets/zh-tw-BZtg_u95.js (1)

Line range hint 1-31: Properly scoped Traditional Chinese locale implementation.
Similar to the Japanese locale module, the structure and usage here conform to expected i18n implementation patterns. No obvious issues or unnecessary console statements were detected.

docs/webapp/prompt.html (1)

31-31: Consistent version update to "1.20.2".
The version change aligns with the PR objective to release 1.20.2. Confirm that all references across the repository are updated accordingly, especially in any installation or release notes.

✅ Verification successful

Let me check for any other version references that might need updating.


Version 1.20.2 is consistently referenced across all relevant files

The version "1.20.2" is consistently updated across:

  • All webapp HTML files (both production and dev versions)
  • package.json and package-lock.json
  • All release JSON files (for Windows, Mac, Linux, and general release)

Note: There is one unrelated reference to version "1.20.0" in a comment in src/background/book/yaneuraou.ts which is discussing historical behavior and doesn't need to be updated. Also, there's an unrelated dependency reference to "resolve": "^1.20.0" in package-lock.json.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify consistency of appVersion references across the repo
rg "appVersion: \"1\.20\.2\"" -A 2

Length of output: 1151


Script:

#!/bin/bash
# Check for any other version references including package.json, version files, etc.
rg "1\.20\." --type-not html

# Also check for potential mismatched versions
rg "version.*1\.20\.[0-9]" --type-not html

Length of output: 1386

docs/webapp-dev/prompt.html (1)

31-31: Version bump is coherent with the project's release plan.
No console logs or lint issues apparent. This change aligns with the new "1.20.2" release.

docs/webapp/monitor.html (1)

31-31: Version update looks good!

The version bump to 1.20.2 is consistent with the release objectives.

docs/webapp/layout-manager.html (1)

33-33: Version update is consistent!

The version bump to 1.20.2 aligns with the release objectives and matches other files.

docs/webapp-dev/layout-manager.html (1)

33-33: Version update is consistent across environments!

The version bump to 1.20.2 is properly synchronized between development and production environments.

Let's verify version consistency across all related files:

✅ Verification successful

Version 1.20.2 is consistently set across all environments and configuration files

The version number "1.20.2" is properly synchronized across:

  • All webapp HTML files in both production (docs/webapp/) and development (docs/webapp-dev/) environments
  • All release configuration files (release-win.json, release-mac.json, release-linux.json, release.json)
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify version consistency across all HTML and JSON files

echo "Checking version numbers in HTML and JSON files..."
rg -g '*.{html,json}' '"1\.20\.[0-9]"' docs/

Length of output: 799

docs/webapp/index.html (2)

37-37: LGTM! Version update is consistent.

The version update to "1.20.2" aligns with the PR objectives and other file changes.


12-12: Verify the existence of updated asset files.

The script and stylesheet references have been updated to new versions. Let's verify these files exist in the assets directory.

Also applies to: 25-25

✅ Verification successful

Asset files verification successful

Both referenced asset files exist in the correct location:

  • docs/webapp/assets/main-B-jRDULs.js
  • docs/webapp/assets/main-BNjJExnj.css
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if the new asset files exist
echo "Checking for new asset files..."
fd -t f "main-B-jRDULs.js|main-BNjJExnj.css" docs/webapp/assets/

Length of output: 212

docs/webapp-dev/index.html (2)

37-37: LGTM! Version is consistent across environments.

The version "1.20.2" matches the production environment, maintaining consistency.


12-12: Verify dev build asset references.

The development build uses different asset references:

  • Script: main-PQHBufhi.js (differs from production)
  • Stylesheet: main-BNjJExnj.css (matches production)

This difference is expected between dev and prod builds.

Also applies to: 25-25

✅ Verification successful

Dev build assets are correctly referenced and present

The verification confirms that both referenced assets exist in the expected location:

  • docs/webapp-dev/assets/main-PQHBufhi.js
  • docs/webapp-dev/assets/main-BNjJExnj.css

The different asset references between dev and prod builds are normal due to the build process generating unique hashed filenames for cache busting.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if the dev asset files exist
echo "Checking for dev asset files..."
fd -t f "main-PQHBufhi.js|main-BNjJExnj.css" docs/webapp-dev/assets/

Length of output: 224

docs/index.zh_tw.html (1)

135-136: Verify GitHub release tag existence.

The link has been updated to point to the v1.20.2 release tag. Let's verify this tag exists in the repository.

✅ Verification successful

Release tag v1.20.2 exists and is correctly referenced

The GitHub API confirms that the release tag v1.20.2 exists in the repository, validating that the documentation link points to a legitimate release version.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if the release tag exists
gh api repos/sunfish-shogi/shogihome/git/refs/tags/v1.20.2 --jq '.ref'

Length of output: 88

docs/index.en.html (1)

129-130: LGTM! Version update is consistent.

The version update from 1.20.1 to 1.20.2 in the download link is correctly implemented and aligns with the PR objectives.

docs/webapp/assets/main-BNjJExnj.css (1)

1-1: Verify if this is the release branch.

As per PR objectives, changes to /docs/webapp should be excluded except on the release branch. Since this PR is for releasing version 1.20.2, please confirm this is being merged into the release branch.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jan 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.74%. Comparing base (efa614c) to head (7057e16).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1058      +/-   ##
==========================================
+ Coverage   76.39%   76.74%   +0.34%     
==========================================
  Files         120      120              
  Lines       15347    15413      +66     
  Branches     2450     2547      +97     
==========================================
+ Hits        11725    11828     +103     
+ Misses       3600     3563      -37     
  Partials       22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunfish-shogi sunfish-shogi merged commit ce5bec4 into main Jan 5, 2025
6 checks passed
This was referenced Jan 5, 2025
@coderabbitai coderabbitai bot mentioned this pull request Jan 19, 2025
7 tasks
@coderabbitai coderabbitai bot mentioned this pull request Jan 26, 2025
7 tasks
@coderabbitai coderabbitai bot mentioned this pull request Feb 15, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant