You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
currently, PreservedObjectHandler#check_existence will decline to validate a CompleteMoab with invalid_checksum status. however, we should considering allowing it to always mark a CompleteMoab as missing (set status to online_moab_not_found). the thinking with the current behavior is that invalid_checksum is a "worse" error than invalid_moab, and so should take precedence since status is a single flat value. however, an entirely missing moab that's in the catalog seems worse than the partial corruption indicated by invalid_checksum, so this is yet another rough edge of our wonky status precedence behavior.
see #1155 for discussion about moving away from the single flat status approach.
#check_existence is actually used by both C2M and M2C, but if it's being called from M2C, it's the result of walking the storage roots for druid directories, so in that scenario the moab directory necessarily exists on disk already. hence this ticket's title.
The text was updated successfully, but these errors were encountered:
@jmartin-sul this is another one for you to determine whether it's still an issue, and if so ... at this point, maybe make a new ticket given the refactoring and close this one.
currently,
PreservedObjectHandler#check_existence
will decline to validate aCompleteMoab
withinvalid_checksum
status. however, we should considering allowing it to always mark aCompleteMoab
as missing (setstatus
toonline_moab_not_found
). the thinking with the current behavior is thatinvalid_checksum
is a "worse" error thaninvalid_moab
, and so should take precedence sincestatus
is a single flat value. however, an entirely missing moab that's in the catalog seems worse than the partial corruption indicated byinvalid_checksum
, so this is yet another rough edge of our wonky status precedence behavior.see #1155 for discussion about moving away from the single flat
status
approach.#check_existence
is actually used by both C2M and M2C, but if it's being called from M2C, it's the result of walking the storage roots for druid directories, so in that scenario the moab directory necessarily exists on disk already. hence this ticket's title.The text was updated successfully, but these errors were encountered: