Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: map FP32 to REAL #261

Merged
merged 6 commits into from
May 31, 2024
Merged

fix: map FP32 to REAL #261

merged 6 commits into from
May 31, 2024

Conversation

ViggoC
Copy link
Contributor

@ViggoC ViggoC commented May 28, 2024

According to the type definition of calcite , REAL is 4 byte floating point and FLOAT is synonym for DOUBLE which is 8 byte floating point.

@CLAassistant
Copy link

CLAassistant commented May 28, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@substrait-io substrait-io deleted a comment from CLAassistant May 29, 2024
@ViggoC ViggoC mentioned this pull request May 31, 2024
Merged
vbarua
vbarua approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@vbarua vbarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! Thanks for adding this.

@vbarua vbarua merged commit 37331c2 into substrait-io:main May 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbarua vbarua vbarua approved these changes

@EpsilonPrime EpsilonPrime EpsilonPrime approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ViggoC @CLAassistant @EpsilonPrime @vbarua