fix: handle LIMIT ALL queries using sentinel value in FetchRel::count #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FetchRels with no count set could not be distinguished from FetchRels with count set to 0. To account for this, the spec now uses -1 as a sentinel value for this.
vbarua
changed the title
|
This work is based on changes introduced in substrait-io/substrait#627 |
EpsilonPrime
approved these changes
Apr 26, 2024
isthmus/src/main/java/io/substrait/isthmus/SubstraitRelVisitor.java
Outdated
Show resolved
Hide resolved
EpsilonPrime
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FetchRels with no count set could not be distinguished from FetchRels
with count set to 0.
To account for this, the spec now uses -1 as a sentinel value for this.
feat: new limit and offset methods on SubstraitBuilder