feat: allow deployment time selection of logging framework #243 #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
vbarua
changed the title
vbarua
changed the title
|
@bestbeforetoday changes look reasonable to me. |
bestbeforetoday
force-pushed
the
slf4j-api
branch
2 times, most recently
from
854a2f3 to
bd6c5d6
Compare
|
@vbarua Thank you for the quick feedback. I've made another pass to refine the change. I've still left the PR in draft as I need to get a review of the CLA from my employer before I can sign off on it. I'll mark it ready for review once I have that done. In the meantime, any feedback or change suggestions are very welcome. |
bestbeforetoday
force-pushed
the
slf4j-api
branch
from
bd6c5d6 to
e096474
Compare
bestbeforetoday
force-pushed
the
slf4j-api
branch
from
e096474 to
79de067
Compare
|
@vbarua I have rebased on the latest commit and this should be ready for review now. |
Depend on slf4j-api instead of the slf4j-jdk14 logging framework. This allows consumers to select their preferred logging framework at deployment time by adding an appropriate SLF4J provider to their runtime classpath. If no SLF4J provider is available at runtime, no logging output will be produced. The code still functions as expected. The isthmus CLI command continues to log using java.util.logging by including the slf4j-jdk14 provider in its runtime classpath. Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
bestbeforetoday
force-pushed
the
slf4j-api
branch
from
79de067 to
61a0033
Compare
vbarua
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depend on slf4j-api instead of the slf4j-jdk14 logging framework. This allows consumers to select their preferred logging framework at deployment time by adding an appropriate SLF4J provider to their runtime classpath.
If no SLF4J provider is available at runtime, no logging output will be produced. The code still functions as expected.
The isthmus CLI command continues to log using java.util.logging by including the slf4j-jdk14 provider in its runtime classpath.