feat(isthmus): add WindowRelFunctionConverter #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbarua
approved these changes
Feb 24, 2024
There was a problem hiding this comment.
Thanks for adding this in!
Extracting the SortFieldConverter and WindowBoundConverter should be useful for anyone trying to implement or extend the function converters, and the WindowRelFunctionConverter should help anyone experimenting with ConsistentPartitionWindowRel.
| public class SortFieldConverter { | ||
|
|
||
| /** Converts a {@link RexFieldCollation} to a {@link Expression.SortField}. */ | ||
| public static Expression.SortField toSortField( |
There was a problem hiding this comment.
✨ Good call extracting this. It should be useful to any downstream uses who wish to implement their own conversion.
| public class WindowBoundConverter { | ||
|
|
||
| /** Converts a {@link RexWindowBound} to a {@link WindowBound}. */ | ||
| public static WindowBound toWindowBound(RexWindowBound rexWindowBound) { |
There was a problem hiding this comment.
✨ Good call extracting this. It should be useful to any downstream uses who wish to implement their own conversion.
ajegou
pushed a commit
to ajegou/substrait-java
that referenced
this pull request
Mar 29, 2024
Extracted out SortFieldConverter and WindowBoundConverter for easier reuse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently added POJOs for ConsistentPartitionWindowRel and WindowRelFunction. #231
The next step is starting to get isthmus support for it, so I went ahead and created WindowRelFunctionConverter so we can start using it to properly bind our window function calls.
It is heavily based on WindowFunctionConverter (although both the input and output changes - input from
RexOvertoRexWinAggCall, and output fromWindowFunctionInvocationtoWindowRelFunctionInvocation), so I extracted some converters to top-level classes to improve reusability.