feat: introduce DefaultExtensionCatalog #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's come up a number of times that we're copying the names of extensions in various places. This change adds a |
contains static strings for default extensions
vbarua
force-pushed
the
vbarua/default-extension-catalog
branch
from
b9c500e to
5bc2786
Compare
vibhatha
approved these changes
Jan 1, 2024
| @@ -25,7 +26,8 @@ public class YamlRead { | |||
|
|
|||
| public static void main(String[] args) throws Exception { | |||
| try { | |||
| System.out.println("Read: " + YamlRead.class.getResource("/functions_boolean.yaml")); | |||
| System.out.println( | |||
There was a problem hiding this comment.
nit: @vbarua just curious do we need a println here? Or should we have used logs?
There was a problem hiding this comment.
This looks to be some old debugging code. Trying to run the main function throws a FileNotFoundException for me, so I'm not sure if it works anymore. I could be worth removing, but I think that would be better as it's own change.
ajegou
pushed a commit
to ajegou/substrait-java
that referenced
this pull request
Mar 29, 2024
contains static strings for default extensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contains static strings for default extensions