Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add MergeJoinRel #201

Merged
merged 3 commits into from
Nov 16, 2023
Merged

feat: add MergeJoinRel #201

merged 3 commits into from
Nov 16, 2023

Conversation

danepitkin
Copy link
Contributor

Closes #198

@danepitkin danepitkin force-pushed the danepitkin/sortmergejoin branch from ee623f7 to f462519 Compare November 8, 2023 17:21
@danepitkin
Copy link
Contributor Author

The MergeJoin implementation is identical to the HashJoin implementation. Any changes unrelated to MergeJoin that you see are just code snippets being moved around (I grouped the three physical operator implementations together for better readability).

vbarua
vbarua approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@vbarua vbarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me! Thanks for the cleanup.

@vbarua vbarua merged commit 237179f into substrait-io:main Nov 16, 2023
ajegou pushed a commit to ajegou/substrait-java that referenced this pull request Mar 29, 2024
@danepitkin
feat: add MergeJoinRel (substrait-io#201)
cc66338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EpsilonPrime EpsilonPrime EpsilonPrime approved these changes

@vbarua vbarua vbarua approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement MergeJoinRel
3 participants
@danepitkin @EpsilonPrime @vbarua