refactor!: rename and move extension associated code #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacques-n
approved these changes
May 23, 2023
ajegou
pushed a commit
to ajegou/substrait-java
that referenced
this pull request
Mar 29, 2024
* refactor: rename FunctionSignatures to ExtensionSignatures * refactor: rename FromProto to ProtoTypeConverter * refactor: rename AbstractFunctionLookup to AbstractExtensionLookup * refactor: rename FunctionLookup to ExtensionLookup * refactor: rename ImmutableFunctionLookup to ImmutableExtensionLookup * refactor: rename FunctionCollector to ExtensionCollector * refactor: move extension related code to io.substrait.extension * refactor: move AdvancedExtension to io.substrait.extension --------- Co-authored-by: Jacques Nadeau <jacques@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Moves and renames code associated w/ extensions
Background
The original extension handling code only dealt with functions, and as such a number of classes associated with this handling had names that included the word
Function.However, extensions can also include custom types, handling for which was added in #144
In that PR I suggested a number of class renames and moves, which are implemented herein.
These changes DO NOT change any functionality in the code.
Change Summary
io.substrait.expression.proto.AdvancedExtensionLookup->io.substrait.extension.AdvancedExtensionLookupio.substrait.expression.proto.AbstractFunctionLookup->io.substrait.extension.AbstractExtensionLookupio.substrait.expression.proto.FunctionCollector->io.substrait.extension.ExtensionCollectorio.substrait.expression.proto.ImmutableFunctionLookup->io.substrait.extension.ImmutableExtensionLookupio.substrait.expression.FunctionLookup->io.substrait.extension.ExtensionLookupio.substrait.function.FunctionSignatures->io.substrait.extension.ExtensionSignaturesio.substrait.function.SimpleExtension->io.substrait.extension.SimpleExtensionio.substrait.type.proto.FromProto->io.substrait.type.proto.ProtoTypeConverterBonus
io.substrait.io.substrait.AdvancedExtension->io.substrait.AdvancedExtension