feat: support proto <-> pojo custom type conversion #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbarua
force-pushed
the
vbarua/type-extension-handling
branch
from
dfc456a to
91996dc
Compare
vbarua
force-pushed
the
vbarua/type-extension-handling
branch
2 times, most recently
from
7de31c6 to
f70a761
Compare
|
CI is failing TestTypeParser tests, however when I run |
vbarua
commented
Apr 26, 2023
| @JsonDeserialize(as = ImmutableSimpleExtension.FunctionSignatures.class) | ||
| @JsonSerialize(as = ImmutableSimpleExtension.FunctionSignatures.class) | ||
| @Value.Immutable | ||
| public abstract static class FunctionSignatures { | ||
| // TODO: Rename to ExtensionSignatures ??? |
There was a problem hiding this comment.
I want to move away from FunctionSignature as this now has types in it as well, but I'm not sure if ExtensionSignature is a good name either. I'm open to suggestions if anyone has a better alternative.
vbarua
force-pushed
the
vbarua/type-extension-handling
branch
from
35ffc02 to
b6ecf31
Compare
|
Running tests using |
jacques-n
approved these changes
May 10, 2023
| @JsonDeserialize(as = ImmutableSimpleExtension.FunctionSignatures.class) | ||
| @JsonSerialize(as = ImmutableSimpleExtension.FunctionSignatures.class) | ||
| @Value.Immutable | ||
| public abstract static class FunctionSignatures { | ||
| // TODO: Rename to ExtensionSignatures ??? |
ajegou
pushed a commit
to ajegou/substrait-java
that referenced
this pull request
Mar 29, 2024
* feat: support proto <-> pojo custom type conversion * test: fix NPE when using Type.NULLABLE/REQUIRED in test --------- Co-authored-by: Jacques Nadeau <jacques@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds machinery for reading type extensions and handling their conversion in POJOs to proto form and back.
All changes were motivated by the example in TestTypeRoundtrip, which:
The majority of changes stem come from:
io.substrait.type.Type.UserDefinedto the type visitors.There a number of classes w/ TODOs to apply renames and/or moves. I held off on applying them in this PR to keep the diff smaller and also check w/ the community to see if they were reasonable before investing time in them.