Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trusted Types support in swg-js #2746

Open
hartmannr76 opened this issue Feb 8, 2023 · 1 comment
Open

Trusted Types support in swg-js #2746

hartmannr76 opened this issue Feb 8, 2023 · 1 comment

Comments

@hartmannr76
Copy link
Contributor

hartmannr76 commented Feb 8, 2023

When running any of the swg.js binaries with Trusted Types enabled on a page, this breaks. There are a handful of places where we set DOM values using sink API's that are blocked with this mode enabled which may prevent other services using this.

To resolve, we should follow the steps in understanding what lines are using invalid methods, and import a library like SafeValues to allow this to use trusted types before assignment.

More details about this can also be seen in the amphtml repo issue

@ChrisAntaki
Copy link
Collaborator

Perhaps we could render HTML with Preact?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants