Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve subctl unit tests #408

Closed
dfarrell07 opened this issue Nov 29, 2022 · 3 comments
Closed

Improve subctl unit tests #408

dfarrell07 opened this issue Nov 29, 2022 · 3 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@dfarrell07
Copy link
Member

Now that we have SonarCloud to better see coverage, it's clear that subctl is the main gap. We currently ahve 4.6% coverage.

https://sonarcloud.io/component_measures?id=submariner-io_subctl&metric=new_coverage&view=list

Add unit tests to get coverage up, maybe targeting 70ish%. This can be split into smaller issues, maybe this should be treated as an epic.

@stale
Copy link

stale bot commented Apr 2, 2023

This issue has been automatically marked as stale because it has not had activity for 60 days. It will be closed if no further activity occurs. Please make a comment if this issue/pr is still valid. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 2, 2023
@dfarrell07 dfarrell07 removed the wontfix This will not be worked on label Apr 4, 2023
@stale
Copy link

stale bot commented Sep 16, 2023

This issue has been automatically marked as stale because it has not had activity for 60 days. It will be closed if no further activity occurs. Please make a comment if this issue/pr is still valid. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 16, 2023
@tpantelis
Copy link
Contributor

Duplicate of #422

@tpantelis tpantelis marked this as a duplicate of #422 Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants