Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Pull Diagnostics model #2095

Closed
rchl opened this issue Oct 22, 2022 · 1 comment · Fixed by #2221
Closed

Support Pull Diagnostics model #2095

rchl opened this issue Oct 22, 2022 · 1 comment · Fixed by #2221
Labels
enhancement protocol updates Issues related to changes in the LSP protocol. Usually because we're out-of-date.

Comments

@rchl
Copy link
Member

rchl commented Oct 22, 2022

LSP-eslint is implementing support for it and removing support for push model (because they don't care about non-VSCode).

https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_pullDiagnostics
@predragnikolic predragnikolic added enhancement protocol updates Issues related to changes in the LSP protocol. Usually because we're out-of-date. labels Oct 23, 2022
@willrowe
Copy link
Contributor

microsoft/vscode-eslint#1534

@jwortmann jwortmann mentioned this issue Mar 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement protocol updates Issues related to changes in the LSP protocol. Usually because we're out-of-date.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for pull diagnostics jwortmann/LSP
3 participants
@rchl @willrowe @predragnikolic