Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to show Find References in the output panel on demand #2084

Closed
rchl opened this issue Oct 11, 2022 · 3 comments
Closed

Ability to show Find References in the output panel on demand #2084

rchl opened this issue Oct 11, 2022 · 3 comments

Comments

@rchl
Copy link
Member

rchl commented Oct 11, 2022

Is your feature request related to a problem? Please describe.
There is an option (show_references_in_quick_panel) to choose whether Find References should use the Output Panel or the Quick Panel for showing references but while I usually want to use the Quick Panel, occasionally I would want to have it output to the Output Panel so that I can jump between all references without having to re-trigger "Find References" all the time.

Describe the solution you'd like

  • Extend lsp_symbol_references with a parameter to choose which output format to use.
  • (Optionally) Expose additional command in the Command Palette/Menus. In that case, figure out the name and how it should be named depending on what is the state of the show_references_in_quick_panel option.

Describe alternatives you've considered
Toggling the show_references_in_quick_panel when needing to use the Output Panel occasionally.

@rchl
Copy link
Member Author

rchl commented Oct 11, 2022

I've also considered changing the existing behavior of LSP: Find References command in the Command Palette depending on whether shift is pressed but unfortunately when triggering commands from there the event object is not passed, even if command defines want_event(self): True

@rchl
Copy link
Member Author

rchl commented Oct 31, 2022

Actually I've realized that my use case would be covered if the quick panel would select by default to file and location closest to the current file/position. Then it wouldn't always scroll me to the first file in the list and I could jump from current to the next one easily.

@rchl
Copy link
Member Author

rchl commented Oct 19, 2023

The improvement done in #2337 should satisfy this use case and I feel doing exactly what I've suggested would complicate things too much.

@rchl rchl closed this as not planned Won't fix, can't repro, duplicate, stale Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant