Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output panels are not (reliably) destroyed if LSP is disabled #2082

Closed
deathaxe opened this issue Oct 8, 2022 · 1 comment · Fixed by #2085
Closed

Output panels are not (reliably) destroyed if LSP is disabled #2082

deathaxe opened this issue Oct 8, 2022 · 1 comment · Fixed by #2085

Comments

@deathaxe
Copy link
Contributor

deathaxe commented Oct 8, 2022

Describe the bug

"Diagnostics" and sometimes "LSP Server Log" output panels are still present after disabling LSP.

To Reproduce
Steps to reproduce the behavior:

  1. Add LSP to "ignored_packages" in Preferences.sublime-settings or run "Package Control: Disable Packgage"

Expected behavior

No LSP related output panel being left.

Environment (please complete the following information):

  • OS: Windows 11
  • Sublime Text version: 4137
  • LSP version: master
  • Language servers used: pyright, json, css, html, lemminx, ...
@rchl
Copy link
Member

rchl commented Oct 8, 2022

We need to get rid of the windows global and make sure that nothing assumes that it's always present. Then we'll be able to do proper cleanup on unload and that should also help with properly destroying references to LSP.

@rchl rchl mentioned this issue Oct 11, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Properly handle disabling of the LSP package sublimelsp/LSP
2 participants
@rchl @deathaxe