Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indentation Tests are not run when calling tests from sublime-syntax #4113

Open
deathaxe opened this issue Apr 28, 2021 · 3 comments
Open

Indentation Tests are not run when calling tests from sublime-syntax #4113

deathaxe opened this issue Apr 28, 2021 · 3 comments

Comments

@deathaxe
Copy link
Collaborator

Description

The pattern on line 46 in Default.sublime-package/run_syntax_tests.py causes indentation tests from not being detected as tests to run for a given syntax.

grafik

It should be modified to something like

match = re.match('^.*SYNTAX TEST (?:reindent)? "(.*?)"', first_line)
if not match:
    continue

Steps to reproduce

  1. Open ST SAFE MODE
  2. View Package Resource -> open PHP.sublime-syntax
  3. Hit ctrl+b to run syntax tests

Expected behavior

All kinds of syntax tests, related to PHP are executed.

Actual behavior

Reindentation tests are skipped.

Environment

  • Build: 4102
  • Operating system and version: Windows 10
@UltraInstinct05
Copy link
Contributor

We may need to modify it beyond just adding reindent since you can have other keywords after SYNTAX TEST like reindent-unindented, reindent-unchanged and then the various stuff added due to implementing symbol tests.

@deathaxe
Copy link
Collaborator Author

Maybe just ([\w-]) to be future prove. I didn't investigate about all the different kinds of tests, tbh.

@jrappen
Copy link
Contributor

jrappen commented Nov 1, 2021

Not related to indentation tests per se, but symbol tests add additional keywords:

  • partial-symbols

Compare #3154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants