Source Code Pro No Color

[wbond]

Description

A user reported losing highlighting with source code pro on macOS 11.

Steps to reproduce

1. Install latest Source Code Pro
2. Open a source file

Expected behavior

Syntax highlighted code.

Actual behavior

No syntax highlighting.

Environment

• Build: 4090
• Operating system and version: macOS 11

[wbond]

The issue seems to be that newer versions of the font include some SVG/color glyphs.

• Source Code Pro cannot be styled in Firefox adobe-fonts/source-code-pro#217
• https://bugzilla.mozilla.org/show_bug.cgi?id=1520157

Currently we detect if a font is a color font via CTFontGetSymbolicTraits() and see if it has kCTFontColorGlyphsTrait. It looks like we'll need to do that, and then check each glyph looking to see if there is an outline. If there isn't, it is a color glyph. If there is an outline, it is a normal glyph. CTFontCreatePathForGlyph() appears to be how to see if there is an "outline".

References:

• https://asciiwwdc.com/2012/sessions/226
• https://bugs.chromium.org/p/skia/issues/detail?id=8779
• https://developer.apple.com/documentation/coretext/1510921-ctfontcreatepathforglyph?language=objc

[BenjaminSchaaf]

Right as I start to look into this they release a new version of Source Code Pro with the SVGs stripped: https://github.com/adobe-fonts/source-code-pro/releases/tag/2.032R-ro%2F1.052R-it%2F1.012R-VAR 😆

[wbond]

We should have a fix for this as part of our next dev build

[BenjaminSchaaf]

Fixed in build 4094.