Skip to content
This repository has been archived by the owner on Sep 21, 2024. It is now read-only.

feat: Rewrite host headers in API client to embed sphere identity in subdomain #726

Merged
merged 1 commit into from
Nov 21, 2023
Merged

feat: Rewrite host headers in API client to embed sphere identity in subdomain #726

merged 1 commit into from
Nov 21, 2023

Conversation

jsantell
Copy link
Contributor

...when feature 'test-gateway' is enabled.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 20, 2023 •
edited
Loading

Test flake analysis

status platform features toolchain
🟢 macos-13 test-kubo,headers,rocksdb stable
🟢 windows-latest test-kubo,headers stable
🟢 macos-13 test-kubo,headers stable
🟡 ubuntu-latest test-kubo,headers nightly
🟢 ubuntu-latest test-kubo,headers stable
🟢 ubuntu-latest test-kubo,headers,rocksdb stable

Flake summary for ubuntu-latest, test-kubo,headers, nightly

     Summary [  40.107s] 176 tests run: 176 passed (2 flaky), 1 skipped
   FLAKY 2/6 [   1.817s] noosphere-ns dht::node::test::test_dhtnode_bootstrap
   FLAKY 2/6 [  17.212s] noosphere::distributed_stress multiplayer::orb_can_render_peers_in_the_sphere_address_book

@jsantell jsantell marked this pull request as ready for review November 20, 2023 19:24
@jsantell jsantell requested a review from cdata November 20, 2023 19:24
cdata
cdata reviewed Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@cdata cdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, minor cleanup requested!

@jsantell jsantell requested a review from cdata November 20, 2023 23:28
@jsantell
feat: Rewrite host headers in API client to embed sphere identity in …
da91223 
…subdomain when feature 'test-gateway' is enabled.
@jsantell
Copy link
Contributor Author

Updated, rejecting if no domain found; downstream usage requires e.g. localhost for 127.0.0.1, but can support a subdomain for counterpart extraction (updated tests)

cdata
cdata approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@cdata cdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the feedback in stride. LGTM!

@cdata cdata merged commit e55f5f1 into main Nov 21, 2023
@cdata cdata deleted the test-gateway branch November 21, 2023 21:29
@github-actions github-actions bot mentioned this pull request Nov 21, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdata cdata cdata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsantell @cdata