Skip to content
This repository has been archived by the owner on Sep 21, 2024. It is now read-only.

feat: Synchronously flush sled DB #540

Merged
merged 1 commit into from
Jul 29, 2023
Merged

feat: Synchronously flush sled DB #540

merged 1 commit into from
Jul 29, 2023

Conversation

jsantell
Copy link
Contributor

.. rather than using sled::Tree::flush_async, which can cause deadlocks. Fixes #403

@jsantell jsantell requested a review from cdata July 28, 2023 20:04
cdata
cdata previously approved these changes Jul 28, 2023
@jsantell jsantell requested a review from cdata July 28, 2023 20:37
@jsantell jsantell changed the title feat: Synchronously flush sled DB in our own async thread feat: Synchronously flush sled DB Jul 28, 2023
Copy link
Collaborator

@cdata cdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot!

@cdata cdata merged commit 7262d5c into main Jul 29, 2023
@cdata cdata deleted the sled-flush-fix branch July 29, 2023 01:58
@github-actions github-actions bot mentioned this pull request Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sled::Tree::flush_async() deadlocks: Intermittent test failures
2 participants