This repository has been archived by the owner on Sep 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 37
fix!: Enable incremental sphere replication #409
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f97bbe8
to
5b85a2b
Compare
5b85a2b
to
6f1261a
Compare
jsantell
previously approved these changes
Jun 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work tackling this challenge!
5001bca
to
33bab3c
Compare
- Most use of `Cid` where it refers to a sphere has been refactored as `Link<MemoIpld>` - Gateway Fetch API block `Bundle` is replaced with a CAR stream - Peer `LinkRecord` proofs are replicated along with the rest of a given sphere's blocks - `MemoIpld` now records a Lamport timestamp to establish a causal order between related versions of its body content - `MemoIpld` signatures previously referred to a proof by CID, but now inline an invoked UCAN JWT - Traversal logic is moved out of `SphereContext`, and the core of it is defined as part of `Sphere`; additional business logic pertaining to replication is implemented as a trait over `HasSphereContext` - Sync now has a configurable retry behavior to cover edge cases when the gateway sphere changes in the time between a fetch and a push (a condition that results in a recoverable "conflict" error on the client)
33bab3c
to
c095baa
Compare
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cid
where it refers to a sphere has been refactored asLink<MemoIpld>
Bundle
is replaced with a CAR streamLinkRecord
proofs are replicated along with the rest of a given sphere's blocksMemoIpld
now records a Lamport timestamp to establish a causal order between related versions of its body contentMemoIpld
signatures previously referred to a proof by CID, but now inline an invoked UCAN JWTSphereContext
, and the core of it is defined as part ofSphere
; additional business logic pertaining to replication is implemented as a trait overHasSphereContext