This repository has been archived by the owner on Sep 21, 2024. It is now read-only.
feat!: Some non-blocking, callback-based C FFI #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Callback APIs added for: - Reading sphere content - Syncing with gateway - Traversing by petname
cdata
force-pushed
the
feat/async-read-and-sync-ffi
branch
from
d7b74a1 to
71199ee
Compare
bfollington
previously approved these changes
Apr 18, 2023
Merged
This was referenced May 8, 2023
Closed
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change proposes a model for Swift-friendly, C-compatible, non-blocking, callback-based FFI. Non-blocking FFI calls are executed by the Tokio runtime, and will be scheduled according to the runtime's internal semantics.
The new FFI style entails two conventional trailing parameters in each callback-based function:
These trailing parameters enable a closure to be created by setting the captured closure state to the context; when the function is called, the captured state is then passed back into it. Importantly, this enables us to write idiomatic-ish closures in Swift as well.
Callback APIs added for:
The older, blocking forms of the FFI have been renamed (e.g.,
ns_sphere_syncis nowns_sphere_sync_blocking) and have been marked as deprecated.