This repository has been archived by the owner on Sep 21, 2024. It is now read-only.
feat: Sphere writes do not block immutable reads #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdata
force-pushed
the
feat/no-lock-sphere-read
branch
2 times, most recently
from
0368ef6 to
90b7163
Compare
cdata
force-pushed
the
feat/no-lock-sphere-read
branch
from
90b7163 to
af06462
Compare
|
Going to go ahead and land this with PR feedback addressed. We can revisit if desired. |
Merged
This was referenced May 8, 2023
Closed
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a
SphereChannel, which enables us to execute read-only and read-write streams of work on spheres concurrently or in parallel. Standard race condition considerations apply: if you intersperse reads and parallel writes, the values that are read will be subject to race results (for example).Although the mutable and immutable sides of the channel do not block each other, it's still possible for immutable reads to reach out to the network (which means any given immutable read may take a beat to finish, subject to network conditions).