This repository has been archived by the owner on Sep 21, 2024. It is now read-only.
Last (hopefully) breaking changes ahead of beta #298
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements the remaining breaking changes to the Noosphere core data structures that we hope to land ahead of the upcoming Private Beta phase of Subconscious. The breaking changes are several, and I'll attempt to document them here:
Renames
The following core domain concepts have been renamed to be more coherent or consistent with the way we have come to talk about them among ourselves:
HAMT layout
The HAMT layout changes implemented in #284 have been almost entirely reverted. With the landing of the typed CID in #297 , we can now leverage the type system to be precise about what means when the key or the value of the HAMT is a CID. This revised approach does lead us to have to be more fiddle-y when crawling the sphere to stream its blocks, but otherwise it gives us improved data layout flexibility while maintaining the benefits of the change made in #284 .
Other breaking changes
The following additional breaking changes were made:
try_
have had that prefix removed to align with our convention elsewherefastcdc
andbase64
crates were updated by breaking increments