Skip to content
This repository has been archived by the owner on Sep 21, 2024. It is now read-only.

Last (hopefully) breaking changes ahead of beta #298

Merged
merged 3 commits into from
Apr 3, 2023

Conversation

cdata
Copy link
Collaborator

@cdata cdata commented Apr 3, 2023

This change implements the remaining breaking changes to the Noosphere core data structures that we hope to land ahead of the upcoming Private Beta phase of Subconscious. The breaking changes are several, and I'll attempt to document them here:

Renames

The following core domain concepts have been renamed to be more coherent or consistent with the way we have come to talk about them among ourselves:

  • Links -> Content
  • Names -> AddressBook / Identities
  • Authorization -> Authority
  • Allowed UCANs -> Delegations
  • Revoked UCANs -> Revocations

HAMT layout

The HAMT layout changes implemented in #284 have been almost entirely reverted. With the landing of the typed CID in #297 , we can now leverage the type system to be precise about what means when the key or the value of the HAMT is a CID. This revised approach does lead us to have to be more fiddle-y when crawling the sphere to stream its blocks, but otherwise it gives us improved data layout flexibility while maintaining the benefits of the change made in #284 .

Other breaking changes

The following additional breaking changes were made:

  • More method names that were prefixed with try_ have had that prefix removed to align with our convention elsewhere
  • Versions of the fastcdc and base64 crates were updated by breaking increments

@cdata cdata requested a review from jsantell April 3, 2023 21:15
Copy link
Contributor

@jsantell jsantell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic improvements and clarifications here @cdata!

rust/noosphere-core/src/view/authority.rs Show resolved Hide resolved
rust/noosphere-core/src/view/mutation.rs Show resolved Hide resolved
rust/noosphere-core/src/data/address.rs Show resolved Hide resolved
@cdata cdata merged commit bd34ab4 into main Apr 3, 2023
@cdata cdata deleted the feat/revised-petname-structure branch April 3, 2023 22:09
@github-actions github-actions bot mentioned this pull request Apr 3, 2023
@github-actions github-actions bot mentioned this pull request Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants