Skip to content
This repository has been archived by the owner on Sep 21, 2024. It is now read-only.

feat: Initial work to get Noosphere building on Windows #228

Merged
merged 1 commit into from
Feb 20, 2023
Merged

feat: Initial work to get Noosphere building on Windows #228

merged 1 commit into from
Feb 20, 2023

Conversation

jsantell
Copy link
Contributor

@jsantell jsantell commented Feb 15, 2023 •
edited
Loading

With these changes, all tests passing on Windows

@jsantell jsantell requested a review from cdata February 15, 2023 21:31
cdata
cdata approved these changes Feb 20, 2023
View reviewed changes
Copy link
Collaborator

@cdata cdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, great work!

For bonus points, it would be sweet to see Windows tests running in CI

@cdata cdata merged commit d1320f0 into main Feb 20, 2023
@cdata cdata deleted the windows branch February 20, 2023 17:42
@github-actions github-actions bot mentioned this pull request Feb 20, 2023
Merged
@jsantell jsantell mentioned this pull request Feb 20, 2023
Closed
This was referenced May 8, 2023
Closed
Closed
Closed
This was referenced Jul 1, 2023
Closed
Merged
@github-actions github-actions bot mentioned this pull request Aug 29, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdata cdata cdata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsantell @cdata