Skip to content
This repository has been archived by the owner on Sep 21, 2024. It is now read-only.

Isolate IpfsClient/KuboClient implementation from Gateway into noosphere_ipfs #203

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

jsantell
Copy link
Contributor

No description provided.

@jsantell jsantell requested a review from cdata January 20, 2023 00:26
Copy link
Collaborator

@cdata cdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks for doing this. There is also some red tape needed to integrate this with our Github Actions workflows for release.

Some areas to look at:

anything_was_released:
${{ steps.release.outputs['rust/noosphere--release_created'] ||
steps.release.outputs['rust/noosphere-api--release_created'] ||
steps.release.outputs['rust/noosphere-cli--release_created'] ||
steps.release.outputs['rust/noosphere-collections--release_created'] ||
steps.release.outputs['rust/noosphere-core--release_created'] ||
steps.release.outputs['rust/noosphere-fs--release_created'] ||
steps.release.outputs['rust/noosphere-into--release_created'] ||
steps.release.outputs['rust/noosphere-ns--release_created'] ||
steps.release.outputs['rust/noosphere-storage--release_created'] }}

"packages": {
"rust/noosphere-api": {},
"rust/noosphere-cli": {
"draft": true
},
"rust/noosphere-collections": {},
"rust/noosphere-core": {},
"rust/noosphere-fs": {},
"rust/noosphere-into": {},
"rust/noosphere-ns": {},
"rust/noosphere-storage": {},
"rust/noosphere": {
"draft": true
}
},

rust/noosphere-cli/src/native/commands/serve/gateway.rs Outdated Show resolved Hide resolved
rust/noosphere-ipfs/src/client.rs Outdated Show resolved Hide resolved
rust/noosphere-ipfs/src/kubo.rs Outdated Show resolved Hide resolved
rust/noosphere-ipfs/src/kubo.rs Outdated Show resolved Hide resolved
@jsantell
Copy link
Contributor Author

Addressed feedback, fixed wasm tests; unsure about the expected return type of IpfsClient::get(Cid) until digging into the http RPC more

Copy link
Collaborator

@cdata cdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this refactor / cleanup!

@cdata cdata merged commit ad1945b into main Jan 23, 2023
@cdata cdata deleted the noosphere-ipfs branch January 23, 2023 18:06
@github-actions github-actions bot mentioned this pull request Jan 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants