-
Notifications
You must be signed in to change notification settings - Fork 37
Isolate IpfsClient/KuboClient implementation from Gateway into noosphere_ipfs
#203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thanks for doing this. There is also some red tape needed to integrate this with our Github Actions workflows for release.
Some areas to look at:
noosphere/.github/workflows/release.yaml
Lines 26 to 35 in d741c8d
anything_was_released: | |
${{ steps.release.outputs['rust/noosphere--release_created'] || | |
steps.release.outputs['rust/noosphere-api--release_created'] || | |
steps.release.outputs['rust/noosphere-cli--release_created'] || | |
steps.release.outputs['rust/noosphere-collections--release_created'] || | |
steps.release.outputs['rust/noosphere-core--release_created'] || | |
steps.release.outputs['rust/noosphere-fs--release_created'] || | |
steps.release.outputs['rust/noosphere-into--release_created'] || | |
steps.release.outputs['rust/noosphere-ns--release_created'] || | |
steps.release.outputs['rust/noosphere-storage--release_created'] }} |
noosphere/release-please-config.json
Lines 7 to 21 in d741c8d
"packages": { | |
"rust/noosphere-api": {}, | |
"rust/noosphere-cli": { | |
"draft": true | |
}, | |
"rust/noosphere-collections": {}, | |
"rust/noosphere-core": {}, | |
"rust/noosphere-fs": {}, | |
"rust/noosphere-into": {}, | |
"rust/noosphere-ns": {}, | |
"rust/noosphere-storage": {}, | |
"rust/noosphere": { | |
"draft": true | |
} | |
}, |
c994716
to
9465153
Compare
…noosphere_ipfs' for usage in noosphere_ns.
9465153
to
993ed87
Compare
Addressed feedback, fixed wasm tests; unsure about the expected return type of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this refactor / cleanup!
No description provided.