Skip to content
This repository has been archived by the owner on Sep 21, 2024. It is now read-only.

dev: First pass on a bootstrap CLI #143

Merged
merged 1 commit into from
Nov 16, 2022
Merged

dev: First pass on a bootstrap CLI #143

merged 1 commit into from
Nov 16, 2022

Conversation

jsantell
Copy link
Contributor

dev: First pass on a bootstrap CLI in noosphere-ns to spin up DHT bootstrap nodes for the name system.

@jsantell jsantell requested a review from cdata November 14, 2022 17:41
cdata
cdata reviewed Nov 14, 2022
View reviewed changes
rust/noosphere-ns/Cargo.toml Outdated Show resolved Hide resolved
cdata
cdata previously approved these changes Nov 14, 2022
View reviewed changes
Copy link
Collaborator

@cdata cdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some incidental questions for my own enrichment, but this looks like a great start ⛵

rust/noosphere-ns/Cargo.toml Outdated Show resolved Hide resolved
rust/noosphere-ns/src/name_system.rs Show resolved Hide resolved
jsantell
jsantell commented Nov 15, 2022
View reviewed changes
Copy link
Contributor Author

@jsantell jsantell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built out the CLI commands a bit with a RunnerConfig (resolved values from the CLI in ready-to-go Multiaddr and Ed25519KeyMaterial form) and Runner.

rust/noosphere-ns/Cargo.toml Show resolved Hide resolved
rust/noosphere-ns/src/bin/bootstrap_nns/cli.rs Outdated Show resolved Hide resolved
rust/noosphere-ns/src/bin/bootstrap_nns/main.rs Outdated Show resolved Hide resolved
rust/noosphere-ns/src/bin/bootstrap_nns/cli.rs Outdated Show resolved Hide resolved
rust/noosphere-ns/src/bin/bootstrap_nns/cli.rs Outdated Show resolved Hide resolved
@jsantell jsantell requested a review from cdata November 15, 2022 00:43
jsantell
jsantell commented Nov 15, 2022
View reviewed changes
Copy link
Contributor Author

@jsantell jsantell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest version cleans up the wasm32 conditionals, removes the keygen fallback (instead for now, is its own command, could defer to other mechanisms, orb, rsync, no preference), addressed comments -- adding bootstrap peers in a follow up

@jsantell jsantell requested a review from cdata November 15, 2022 22:01
cdata
cdata approved these changes Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@cdata cdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start for this stand-alone binary!

@cdata cdata merged commit c5f2710 into main Nov 16, 2022
@cdata cdata deleted the dht-bootstrap branch November 16, 2022 01:03
@github-actions github-actions bot mentioned this pull request Nov 16, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdata cdata cdata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsantell @cdata