This repository has been archived by the owner on Sep 21, 2024. It is now read-only.
feat: Add SphereFS read/write to FFI
#141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 14, 2022
Open
This change also adds automated Swift testing to our Github Actions workflow. BREAKING CHANGE: Some FFI interfaces now have simplified interfaces.
The new test-specific build will cut down Github Actions runner usage time by ~60% for Apple-related work.
cdata
force-pushed
the
feature/ffi-read-write-sphere
branch
from
b5faa63 to
0e9e0d9
Compare
jsantell
approved these changes
Nov 14, 2022
This was referenced Nov 14, 2022
Merged
Closed
This was referenced May 8, 2023
Closed
Closed
Closed
Closed
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces reading and writing-related FFI functions and structs to enable basic access to local sphere data. A test has been implemented to demonstrate the FFI in action on the Swift side.
This change also adds automated Swift testing to our Github Actions workflow. A specialization of the Apple library build that only targets MacOS x86_64 has been created so that we can run Swift tests on a library created on-demand for the current branch without wasting runner minutes. An extension to the release flow has been included that does everything except commit the work needed for #135 .
New brand images have also been added to the README as of this change.
BREAKING CHANGE: Some FFI interfaces now have simplified interfaces.
Fixes #133