Add Faker::ChileRut #893
Add Faker::ChileRut #893
Conversation
vbrazo
force-pushed
the
master
branch
5 times, most recently
from
a359def
to
a5d7731
Compare
There was a problem hiding this comment.
Overall looks good 👍
We have an IDNumber object that provides a few ssn methods. I think we should move your code to this object and then we'd be good to go.
Could you also please update the changelog and add your name + PR?
|
Could you please rebase/update your branch with master and fix the |
|
Sorry for the late response! I really think Chileans would benefit a lot more from having this on a separate module since social security numbers from Spain are kinda different from the Chilean RUT. I put 'social security number' so it could be easily understood the sort of equivalence. |
|
No problem. We can work with ChileRUT. Let me know when you update the branch. |
vbrazo
changed the title
|
@oxfist any updates on this PR? |
|
@vbrazo it's been really busy for me lately, so I apologize for the delay. I'm not really sure how to rebase my branch and I don't want to screw it up. Could you help me with it? I forked the repo and pushed the changes to that fork. |
|
👍 |
* Added ChileRUT class for generating Modulo 11 chilean RUTs and check digits. * Improved ChileRUT docs. * Update chile_rut.rb * Update test_determinism.rb * Update test_faker_chile_rut.rb * Update CHANGELOG.md * Update chile_rut.md * Update README.md * Update chile_rut.md * Update test_faker_chile_rut.rb
No description provided.