Faker::Lorem.multibyte for multibyte chars #817
Conversation
This is to generate random characters with multibyte (often found in
different languages or signs like emojii)
vbrazo
force-pushed
the
master
branch
5 times, most recently
from
a359def
to
a5d7731
Compare
There was a problem hiding this comment.
A couple of things:
- you should update the documentation -
doc/lorem.md - you should rebase with master and fix the rubocop violations
I see that you are a first-time contributor. Please check our contributing file out. There are instructions that you should read and remember in your next PRs.
|
@frankywahl I had free time today, rebase your branch with master and add the missing docs. |
|
I think we could start displaying the multibytes for now and eventually we could add more functionalities as you pointed in the description. |
There was a problem hiding this comment.
👍 Thanks for updating this @vbrazo. I thought of the PR as a means to open the discussion, not fully fledged, but with you changes, it's now all good. Thanks!
|
@frankywahl it would be cool if we could add more locales to this new object and just display a multibyte |
|
@frankywahl I had free time today and just added the option to display only a sample 👍 |
* Faker::Lorem.multibyte for multibyte chars
This is to generate random characters with multibyte (often found in
different languages or signs like emojii)
* Add lorem docs and remove unnecessary locale
* Minor fix
* Add multibyte locale and display a sample
This is to generate random characters with multibyte (often found in
different languages or signs like emojii)
This is to open discussion on adding support for multibyte. While this PR does work, it probably needs some love as to the best location for this (
Ipsum?), whether it should give 1 multibyte character or multiple and wether we can make a sentence that could mix and match between multibyte and non-multibyte.