Add Faker for Famous Last Words

[susiirwin]

Add a Faker Module for Famous Last Words - phrases from People who passed away from a variety of causes but left us with some great last Phrases. Test and Documentation included.

[b264]

I don't think this code is being tested; this method can be removed without the test failing

[b264]

The entire class << self block can be removed, I think

[susiirwin]

You are absolutely right! Thanks for pointing this out... I am going to continue working on this. I need to adjust my test to reflect the correct regex.

[b264]

It's the flexible :famous_last_words combined with https://github.com/stympy/faker/blob/94db84f53c9623cdcbdccd0081f39c7f2684e9da/lib/faker.rb#L174

[vbrazo]

Your changes look good. I think you still have work to do here, right?

A couple of things before we review this PR:

• Add your name + PR in the changelog.md
• Rebase with master and fix all the Rubocop violations
• After pushing the new changes, check Travis and Coveralls out to see if things are well

[vbrazo]

@susiirwin are you still interested in working in these changes? If not, we could assign to another contributor.

[susiirwin]

I would really like to :) sorry I have left it dormant for so long! I will start working on it again soon.

[susiirwin]

Will be working on this PR this week :) thanks for the encouragement!

[vbrazo]

Awesome @susiirwin 💯

Well, I'm here to help, so if you need someone to review your changes, have doubts, want to discuss something or would like to do a pair programming with me, let me know.

[vbrazo]

Could you rebase with master and fix the Rubocop violations? After rebasing, you'll need to install the new gems and then just run bundle exec rubocop -a. Let me know if you need help while rebasing @susiirwin

[susiirwin]

@vbrazo - a second set of eyes would be AMAZING :) I am pretty sure i did the rebase and fixed the extra line errors that Rubocop was angry about. BUT i am not sure that it is correct still? Can you take a look and offer some suggestions? Thanks in advance....

[susiirwin]

Thank you!!!

[susiirwin]

Thanks for all of your help @vbrazo! 💯

[vbrazo]

I saw that you created a new branch to work on the desserts API. Great :)

You should update your master branch. You should have the latest merged PRs there. Once it's up-to-date, you can create a new branch based in your new file structure.

To update your master branch in your repository, you should do something like this in your terminal:

git remote -v
git remote add faker git@github.com:stympy/faker.git  # if you don't have the faker remote address yet
git checkout master
git reset --hard HEAD~50 # because your branch master might have things that don't matter anymore
git pull faker master # now you're good to go
git push -f [your remote address] master # now your master is updated

# if you want to update your SusiIrwin-Dessert-Faker branch after updating master:
git checkout SusiIrwin-Dessert-Faker
git merge --no-ff master
git status  # to see what files have conflicts. Fix the conflicts and commit them
git add .
git commit -m 'something'
git push -f [your remote address] SusiIrwin-Dessert-Faker

I made a few changes. Notice that

• the changelog.md has changed. Now we include the PR + name at the top. In the HEAD section.
• locales changed a bit too. Now you have a file for them.

[vbrazo]

Notice that we are using Rubocop right now. I'm not sure if you are familiar with this gem, but now if you run rake, you'll run the tests and after that rubocop will be executed. Most rubocop issues are fixed with bundle exec rubocop -a, others you need to google and fix. Rubocop is great to control the code quality of your project.

[vbrazo]

I think this PR looks good and is good to go. Thanks for the hard work 👍

Let me know when the Dessert API is done.

[vbrazo]

I just updated the contributors.md based on our discussions. New file. Thanks a lot.