Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix german commerce translations #616

Merged
merged 2 commits into from
Jun 19, 2018

Conversation

weh
Copy link
Contributor

@weh weh commented Jun 28, 2016

Add German Commerce locales:

  • Faker::Commerce.department
  • Faker::Commerce.product_name
  • Faker::Commerce.material
  • Faker::Commerce.product

Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You should rebase/update your branch with master and fix the rubocop violations.

@vbrazo vbrazo merged commit 13b367a into faker-ruby:master Jun 19, 2018
@vbrazo vbrazo changed the title add german commerce translations fix german commerce translations Jun 19, 2018
@vbrazo vbrazo changed the title fix german commerce translations Fix german commerce translations Jun 19, 2018
@vbrazo vbrazo self-requested a review July 19, 2018 01:31
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants