Adds the Faker::Sports::Basketball Generator

[ecbrodie]

Motivated by my discovery of the Faker::Football generator and the fact that my two favourite hobbies are basketball and programming, I decided to create a generator for basketball. Introducing the Faker::Sports::Basketball generator!

For now, I have added the following method to the generator (of course, this generator should be open for new methods or even new data added to its existing methods):

• positions: The 5 standard basketball positions
• teams: The names of the 30 teams in the NBA
• players: The names of some NBA players. Since this list in real life is huge, I decided to stick to just the participants of the 2019 NBA All Star Game
• coaches: The names of NBA coaches, current as of PR publication

PR CAVEATS

• I named my generator Basketball, but it's very possible that NBA is a more appropriate name. Although the NBA is the most recognizable league in the world, there are of course other popular leagues around the globe (NCAA, Euroleague, etc). It's possible that a generator named "Basketball" should also be including data from more leagues than just basketball
• I introduced a new module called Sports and nested the Basketball generator inside of it. If this is not welcome, I am okay with moving Basketball to the global Faker namespace. I thought this could be useful because I can see how new generators could naturally be grouped into Sports. But, if this move is accepted, then a future PR could move the Football and WorldCup generators into Sports
• I did not add any files into the unreleased directory. I was not sure if this was necessary. It was definitely not mentioned in the contributing guide.

Happy hooping!

[vbrazo]

Looks good 👍

You should update our unreleased_README.md and add the Sport namespace there.

Could you please move Faker::Football to Faker::Sports::Football?

[vbrazo]

I think Faker::WorldCup should be moved to the Sport namespace too. I mean Faker::Sports::WorldCup.

[vbrazo]

This namespace discussion started here: #1318

[vbrazo]

I'll do these changes in a separate PR.

[ecbrodie]

@vbrazo I'm happy to see my contribution merged in :D. Thanks for picking up those extra tasks. I agree that they should be in a separate PR, in order to maintain small PRs.