Allow subdomains for Internet.domain_name #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mucho-al-dente
force-pushed
the
subdomains
branch
from
5db4de0
to
ad69453
Compare
abdelkarim00
approved these changes
Feb 10, 2019
Zeragamba
suggested changes
Feb 11, 2019
| @@ -79,8 +79,12 @@ def password(min_length = 8, max_length = 16, mix_case = true, special_chars = f | |||
| temp | |||
| end | |||
|
|
|||
| def domain_name | |||
| with_locale(:en) { [Char.prepare(domain_word), domain_suffix].join('.') } | |||
| def domain_name(subdomain = false) | |||
There was a problem hiding this comment.
documentation should be updated to include this new param
There was a problem hiding this comment.
@SpyMaster356 No problem, have done that and updated the PR
mucho-al-dente
force-pushed
the
subdomains
branch
from
ad69453
to
b1e379d
Compare
Zeragamba
approved these changes
Feb 12, 2019
|
looks good to me, though be careful with rewriting history. You shouldn't need to force-push anything. |
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Allow subdomains for Internet.domain_name * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.