Deprecate Faker::Number.decimal_part and .leading_zero_number

[vbrazo]

In version 2.0, Faker::Number methods are going to return integer, so we need to deprecate a few methods that won't make sense soon.

Checklist

• Deprecate Faker::Number.decimal_part
• Deprecate Faker::Number.leading_zero_number

This PR is related to #510.

[tjwallace]

Faker::Number.decimal uses Faker::Number.decimal_part - is there a replacement?

[vbrazo]

Yeah! Faker::Number.decimal should've been deprecated too. Thanks for letting me know!

There is no replacement yet @tjwallace any suggestions?

[vbrazo]

@tjwallace the replacement would be converting the strings to decimals.

I'll think about it. Feel free to open a PR in case you come up with a good idea.

If we make it, we don't need to deprecate/remove the methods.

[dadamschi]

If I think I am following this correctly, Faker:Number.decimal in v2 is not using Faker:Number.decimal_part.
https://github.com/stympy/faker/blob/v2/lib/faker/default/number.rb#L14

[vbrazo]

@dadamschi I haven't had time to change it yet, but our final idea was to keep Faker:Number.decimal and Faker:Number.decimal_part and return them as decimal instead of string.

[dadamschi]

I think that makes sense. Thanks for clearing that up.

And, FWIW, what is returned for decimal_part is called fractional_part. https://en.wikipedia.org/wiki/Fractional_part

[aleksejkuzmin]

I like the idea to return decimal instead of string, but faker itself uses deprecated methods, thus you have deprecation messages even if you don't use deprecated methods directly. E.g. with faker-1.9.6

[1] pry(main)> Faker::Number.decimal
NOTE: Faker::Number.decimal_part is deprecated; use  instead. It will be removed on or after 2019-06-01.
Faker::Number.decimal_part called from /Users/hideman/.rvm/gems/ruby-2.5.1/gems/faker-1.9.6/lib/faker/default/number.rb:34.
NOTE: Faker::Number.leading_zero_number is deprecated; use  instead. It will be removed on or after 2019-06-01.
Faker::Number.leading_zero_number called from /Users/hideman/.rvm/gems/ruby-2.5.1/gems/faker-1.9.6/lib/faker/default/number.rb:29.
=> "27863.07"

Doesn't it make sense to change internal implementation too? Otherwise tests output become messy

[vbrazo]

@aleksejkuzmin this issue talks about that #1655 and it'll be fixed in v2.

[aleksejkuzmin]

@vbrazo sorry, didn't spot that issue. thanks for answering!