Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish between 'brand' and 'name' #1514

Merged
merged 2 commits into from
Jan 23, 2019
Merged

Distinguish between 'brand' and 'name' #1514

merged 2 commits into from
Jan 23, 2019

Conversation

iwaim
Copy link
Contributor

@iwaim iwaim commented Jan 23, 2019

These are name of beer.

  • Kirin Inchiban
  • Delirium Tremens
  • Delirium Noctorum
  • Sapporo Premium

These are name of beer.
- Kirin Inchiban
- Delirium Tremens
- Delirium Noctorum
- Sapporo Premium
@vbrazo vbrazo assigned vbrazo and iwaim and unassigned vbrazo Jan 23, 2019
@vbrazo vbrazo self-requested a review January 23, 2019 15:54
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch 👍

@vbrazo vbrazo merged commit f496864 into faker-ruby:master Jan 23, 2019
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* Distinguish between 'brand' and 'name'

These are name of beer.
- Kirin Inchiban
- Delirium Tremens
- Delirium Noctorum
- Sapporo Premium

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants