Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in Faker::Code documentation #1513

Merged
merged 3 commits into from
Jan 22, 2019
Merged

Fix typo in Faker::Code documentation #1513

merged 3 commits into from
Jan 22, 2019

Conversation

iox
Copy link
Contributor

@iox iox commented Jan 21, 2019

No description provided.

vbrazo
vbrazo approved these changes Jan 22, 2019
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this typo.

Could you also update the doc/v1.9.2/code.md and doc/unreleased/code.md please?

@vbrazo vbrazo self-assigned this Jan 22, 2019
@vbrazo vbrazo assigned iox and unassigned vbrazo Jan 22, 2019
@vbrazo
Copy link
Member

vbrazo commented Jan 22, 2019

I just double checked and noticed that these files are already updated. Thanks 👍

@vbrazo vbrazo merged commit 8ac5b31 into faker-ruby:master Jan 22, 2019
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@iox @vbrazo
Fix typo in Faker::Code documentation (faker-ruby#1513)
3407319 
* Fix typo in Faker::Code documentation

* Update code.md

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo vbrazo approved these changes

Assignees

@iox iox

Labels
📘 Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iox @vbrazo