Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Faker::Books::CultureSeries #1493

Merged
merged 7 commits into from
Jan 5, 2019
Merged

Add Faker::Books::CultureSeries #1493

merged 7 commits into from
Jan 5, 2019

Conversation

richardbulger
Copy link
Contributor

Adds the Culture series of novels by Ian M. Banks

lib/locales/en/culture_series.yml Outdated Show resolved Hide resolved
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you wrap this module in the Book namespace: Faker::Book::CultureSeries?

@richardbulger
Copy link
Contributor Author

Requested changes have been made

@vbrazo vbrazo changed the title Culture series, Ian M. Banks Add Faker::Books::CultureSeries Dec 30, 2018
@vbrazo vbrazo merged commit e315adf into faker-ruby:master Jan 5, 2019
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* Initial commit for Culture Series tasks

* Adds tests for Culture Series

* Adds documentation for Culture Series

* Reformats to agreed standard

* Moves CultureSeries to new Books namespace

* Adds missing end of file newline

* Corrects documentation mistake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants