-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Faker::TvShows::TheExpanse #1487
Conversation
doc/v1.9.1/the_expanse.md
Outdated
@@ -0,0 +1,11 @@ | |||
# Faker::TheExpanse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v1.9.1
was already released. This file should be in the doc/unreleased
folder. You have to update unreleased_README.md
too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've updated as requested.
@@ -0,0 +1,11 @@ | |||
# Faker::TheExpanse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be Faker::TvShows::TheExpanse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
* add the expanse tv show data * fix typo in the_expanse.md * move .md to doc/unreleased and update unreleased README * Update the_expanse.md
I've added data from one of my favorite shows, a Sci-Fi series called The Expanse. This is my first ever contribution to an open source project. Please let me know if this is adequate or if any changes are needed.
All tests are passing and I believe I've added all the file types needed in order to implement a new set of random data: