Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Blockchain namespace #1481

Merged
merged 5 commits into from
Nov 19, 2018
Merged

Add Blockchain namespace #1481

merged 5 commits into from
Nov 19, 2018

Conversation

vbrazo
Copy link
Member

@vbrazo vbrazo commented Nov 18, 2018

Checklist

  • Faker::Bitcoin => Faker::Blockchain::Bitcoin
  • Faker::Ethereum => Faker::Blockchain::Ethereum
  • Faker::Tezos => Faker::Blockchain::Tezos

This PR is related to #1318

@vbrazo vbrazo self-assigned this Nov 18, 2018
@vbrazo
Copy link
Member Author

vbrazo commented Nov 18, 2018

@Pierre-Michard I remember that you implemented Faker::Tezos. Let me know what you think about this namespace.

@Pierre-Michard
Copy link
Contributor

Hi Victor, that's a brilliant idea. that organizes the project and clarifies the purpose of those recipes.

@vbrazo vbrazo merged commit e8e0e1c into faker-ruby:master Nov 19, 2018
@vbrazo vbrazo deleted the deprecate/add-blockchain-namespace branch November 19, 2018 11:59
@vbrazo
Copy link
Member Author

vbrazo commented Nov 19, 2018

Thanks for reviewing 🥇

davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* Deprecate ::Bitcoin

* Deprecate ::Ethereum

* Deprecate ::Tezos

* Update unreleased_README.md

* Minor fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants