Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Faker::Football.position #1438

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Add Faker::Football.position #1438

merged 1 commit into from
Oct 23, 2018

Conversation

fblupi
Copy link
Contributor

@fblupi fblupi commented Oct 23, 2018

No description provided.

@fblupi
Copy link
Contributor Author

fblupi commented Oct 23, 2018

Seems to be failing a test from a model I haven't modified (as you can see in the files changed)

vbrazo
vbrazo approved these changes Oct 23, 2018
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks good. Thanks for contributing 👍

@vbrazo vbrazo changed the title Add Football Positions Add Faker::Football.position Oct 23, 2018
@vbrazo vbrazo merged commit a66f07a into faker-ruby:master Oct 23, 2018
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@fblupi @vbrazo
Add Football Positions (faker-ruby#1438)
dfb0daa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo vbrazo approved these changes

Assignees

@fblupi fblupi

Labels
💡 Issue: Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fblupi @vbrazo