Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Faker::DrivingLicence #1433

Merged
merged 3 commits into from
Oct 26, 2018
Merged

Add Faker::DrivingLicence #1433

merged 3 commits into from
Oct 26, 2018

Conversation

jellyfunk
Copy link
Contributor

Supports generating driving licence numbers in the 2 formats used in the UK

@vbrazo vbrazo changed the title Add module for generating driving licences Add Faker::DrivingLicence Oct 22, 2018
vbrazo
vbrazo requested changes Oct 24, 2018
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing 👍

Travis is red. Could you please fix the rubocop offenses?

@jellyfunk
Copy link
Contributor Author

Hiya, thanks for looking at the PR!
I've merged up and everything's passing locally

vbrazo
vbrazo approved these changes Oct 26, 2018
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I liked the british_driving_licence method. It's clean.

Thanks for updating the unreleased_CONTENT.md 👍

I'll add the Brazilian driving license in a near future as well.

@vbrazo vbrazo merged commit 7c3ebf9 into faker-ruby:master Oct 26, 2018
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@jellyfunk @vbrazo
Add module for generating driving licences (faker-ruby#1433)
f2972d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo vbrazo approved these changes

Assignees

@jellyfunk jellyfunk

Labels
💡 Issue: Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jellyfunk @vbrazo @fleetsource-matt