Add Faker::TvShow namespace #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since we will have namespaces now, we can sort the tests into folders to make it easier to navigate
Also leave deprecation warning in both the top level and the movies namespace
and add missing unit tests
and add missing documentation
Zeragamba
commented
Oct 22, 2018
vbrazo
added
💡 Issue: Feature Request
Deprecation
and removed
💡 Issue: Feature Request
labels
vbrazo
reviewed
Oct 30, 2018
|
sorry for the delay in getting that stuff merged |
|
any additional changes needed for this? |
vbrazo
reviewed
Nov 9, 2018
| def character | ||
| fetch('aqua_teen_hunger_force.character') | ||
| Faker::TvShows::AquaTeenHungerForce.character | ||
| end |
| end | ||
|
|
||
| deprecate :character, 'Faker::TvShows::AquaTeenHungerForce.character', 2018, 10 |
There was a problem hiding this comment.
I think the deprecate dates should be 2018, 12
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| require_relative 'test_helper' | |||
|
|
|||
| class TestFakerRickAndMorty < Test::Unit::TestCase | |||
| class TestDeprecateRickAndMorty < Test::Unit::TestCase | |||
There was a problem hiding this comment.
When we call a deprecate message, we get a standard message. Could we test if we get this behaviour?
| end | ||
|
|
||
| deprecate :character, 'Faker::TvShows::SouthPark.character', 2018, 10 | ||
| deprecate :quote, 'Faker::TvShows::SouthPark.quote', 2018, 10 |
There was a problem hiding this comment.
We need to review this class because I've changed its namespace recently and we haven't released my PR yet, so I think the deprecate should be different #1403
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* add TvShows namespace * move BojackHorseman into TvShows namespace * update documentation for BojackHorseman * reorganize the new test since we will have namespaces now, we can sort the tests into folders to make it easier to navigate * move AquaTeenHungerForce to TvShows namespace * remove Bojack from the ignored subclasses * move BreakingBad to TvShows * move Buffy to TvShows * move DrWho to TvShows * update Readme * move Community to TvShows * make deprecated methods wrappers around new ones * add flexible tag to new classes * move DumbAndDumber to TvShows * update Faker::TvShows::BreakingBad to use class << self style * fix filename * Move FamilyGuy to TvShows * move VentureBros to TvShows * move TwinPeaks to TvShows * move Friends to TvShows * move SouthPark to TvShows Also leave deprecation warning in both the top level and the movies namespace * move GameOfThrones to TvShows * move TheITCrowd to TvShows * move HeyArnold to TvShows * move HowIMetYourMother to TvShows * move NewGirl to TvShows * move ParksAndRec to TvShows * move RickAndMorty to TvShows * move Seinfeld to TvShows * move SiliconValley to TvShows * move Simpsons to TvShows * move StarTrek to TvShows * move StrangerThings to TvShows and fix typos * move TheFreshPrinceOfBelAir to TvShows * move TheThickOfIt to TvShows and add missing unit tests * move Stargate to TvShows and add missing documentation * add StarTrek back into the readme * add flexible tag to FamilyGuy * fix copy-paste error with TheITCrowd docs * please the Rubocop * remove windows platform from .lock file * update unreleased README * Restore README * Add a few comments - faker.rb * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I got all the TV shows in the current list into the new namespace.
Please double check the deprecation notices, as there was a lot of copy-paste-next file-copy-paste-etc..